UI: Port WithTooltip from popper.js to react-aria and adjust internals [2/3] #32493
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #32492
Closes #32249
What I did
Ported WithTooltip and friends to react-aria
Replaced Popper.js with react-aria
Removed WithTooltipPure and WithTooltipState in favour of a single WithTooltip that supports both controlled and uncontrolled usage with the same API as WithPopover and WithMenu
Removed many unused props and renamed some to align with other components
Added ability to make focus-only tooltip so we can provide KB navigation shortcut hints in the future sidebar
Reworked stories to match current API
Reworked Tooltip to have hasChrome and color like Popover, except it doesn't have a close button since it's not interactive
Removed a lot of arrow-related code we weren't using
Added stories for Tooltip
Removed default margin in TooltipNote to make overlay positioning more coherent (use offset on WithTooltip/WithMenu/WithPopover instead)
Deprecated Tooltip-adjacent components
Migrated internal UI code
data-shortcuts-enabledto provide a better default in the Preview context where the attribute is missing on body; this lets our own stories show shortcut tooltips inside our own StorybookChecklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
unit testsManual testing
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>