Fix mqtt disconnect due to appId permission bug when namespace policies update #1813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oneby-wang
requested review from
Technoboy-,
coderzc and
mattisonchao
as code owners
|
@oneby-wang:Thanks for your contribution. For this PR, do we need to update docs? |
oneby-wang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
MQTTConsumer appId field is equivalent to the userRole in Authentication. The appId field will be used to do checkPermissionsAsync when namespace policies update.
https://github.com/apache/pulsar/blob/0a949de4bfa3734194be87a8655763a4411be1b6/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java#L1042-L1044
Modifications
Before: appId is set to ""
After: appId is set to connection.getUserRole()
Verifying this change
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)