[DISCARDED] Add failing testcase for MID/HASH generation: ROLE not written back #2576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: This change is the next step towards generating SPDX-Req-ID and SPDX-Req-HKey in accordance with the Linux Kernel Requirements Template proposal. Problem: - When auto-generating MID and HASH, we want to only rewrite these fields. All other fields should stay the same for the SDoc sidecar files. - The SPDX-Req-HKey calculation algorithm shall include all fields of the combined requirement node (sidecar + source code). Exception: MID and hash key fields. Solution: - The `ManageAutoUIDCommand` has been upgraded to generate the `MID/SPDX-Req-ID` (SDoc and sidecar respectively) and `HASH` (SDoc only). - The `SDocNodeFieldOrigin` field was introduced on the SDocNodeField class to enable new code that prevents the source node fields to be written back to SDoc files when the `manage autouid` command is invoked. - The hash calculation procedure was fixed to contain calculating the hash over all fields of the merged node, i.e., both the SDoc and sidecar fields. The previous implementation was incorrect. - `RELATION_FIELD` previously was not written by the `SDWriter` class. It is implemented now as part of this changeset because otherwise the diff expectation in the integration test highlights that this field is not present in the output document. Important notes: - The `SPDX-Req-HKey` is listed as `Sidecar` in the proposal which means that a source node must always have a sidecar if a hash calculation is desired. We could further clarify if this is what the ELISA group wants.
On manage auto-uid, - "ROLE: TestCase" will correctly be written back, - "ROLE: TestDefinition" will *not* be written back.
stanislaw
force-pushed
the
stanislaw/node_field_origin
branch
from
36ed096 to
c18e9f7
Compare
Collaborator
|
This should be fixed by #2577. |
stanislaw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a failing testcase for #2566.
On manage auto-uid,
DON'T MERGE: I've set the target branch to
stanislaw/node_field_originso that github shows the correct diff. If you want to merge it, cherry-pick the commit manually or tell me to reset the target branch to main.