Rename serialization methods from Data() to Bytes()

Author: stringintech

kernel/block.go

@@ -47,8 +47,8 @@ func (b *Block) Hash() (*BlockHash, error) {
 	return hash, nil
 }
 
-// Data returns the serialized block data
-func (b *Block) Data() ([]byte, error) {
+// Bytes returns the serialized block
+func (b *Block) Bytes() ([]byte, error) {
 	checkReady(b)
 
 	// Use the callback helper to collect bytes from btck_block_to_bytes

kernel/block_test.go

@@ -54,10 +54,10 @@ func TestBlockFromRaw(t *testing.T) {
 		t.Logf("Expected hash: %s", expectedHash)
 	}
 
-	// Test getting block data
-	data, err := block.Data()
+	// Test getting the serialized block
+	data, err := block.Bytes()
 	if err != nil {
-		t.Fatalf("Block.Data() error = %v", err)
+		t.Fatalf("Block.Bytes() error = %v", err)
 	}
 
 	if len(data) != len(genesisBytes) {

kernel/script_pubkey.go

@@ -31,8 +31,8 @@ func NewScriptPubkeyFromRaw(rawScriptPubkey []byte) (*ScriptPubkey, error) {
 	return scriptPubkey, nil
 }
 
-// Data returns the serialized script pubkey data
-func (s *ScriptPubkey) Data() ([]byte, error) {
+// Bytes returns the serialized script pubkey
+func (s *ScriptPubkey) Bytes() ([]byte, error) {
 	checkReady(s)
 
 	return writeToBytes(func(writer C.btck_WriteBytes, user_data unsafe.Pointer) C.int {

kernel/script_pubkey_test.go

@@ -27,10 +27,10 @@ func TestScriptPubkeyFromRaw(t *testing.T) {
 	}
 	defer scriptPubkey.Destroy()
 
-	// Test getting script pubkey data
-	data, err := scriptPubkey.Data()
+	// Test getting the serialized script pubkey
+	data, err := scriptPubkey.Bytes()
 	if err != nil {
-		t.Fatalf("ScriptPubkey.Data() error = %v", err)
+		t.Fatalf("ScriptPubkey.Bytes() error = %v", err)
 	}
 
 	if len(data) != len(scriptBytes) {
@@ -71,22 +71,22 @@ func TestScriptPubkeyCopy(t *testing.T) {
 	}
 
 	// Verify copy has same data
-	originalData, err := scriptPubkey.Data()
+	originalData, err := scriptPubkey.Bytes()
 	if err != nil {
-		t.Fatalf("Original ScriptPubkey.Data() error = %v", err)
+		t.Fatalf("Original ScriptPubkey.Bytes() error = %v", err)
 	}
 
-	copyData, err := scriptCopy.Data()
+	copyData, err := scriptCopy.Bytes()
 	if err != nil {
-		t.Fatalf("Copied ScriptPubkey.Data() error = %v", err)
+		t.Fatalf("Copied ScriptPubkey.Bytes() error = %v", err)
 	}
 
 	if hex.EncodeToString(originalData) != hex.EncodeToString(copyData) {
 		t.Error("Copied script pubkey data doesn't match original")
 	}
 }
 
-func TestScriptPubkeyData(t *testing.T) {
+func TestScriptPubkeyBytes(t *testing.T) {
 	scriptHex := "76a914389ffce9cd9ae88dcc0631e88a821ffdbe9bfe26158088ac"
 	scriptBytes, err := hex.DecodeString(scriptHex)
 	if err != nil {
@@ -100,9 +100,9 @@ func TestScriptPubkeyData(t *testing.T) {
 	defer scriptPubkey.Destroy()
 
 	// Test serializing script to bytes
-	serialized, err := scriptPubkey.Data()
+	serialized, err := scriptPubkey.Bytes()
 	if err != nil {
-		t.Fatalf("ScriptPubkey.Data() error = %v", err)
+		t.Fatalf("ScriptPubkey.Bytes() error = %v", err)
 	}
 
 	if len(serialized) == 0 {

kernel/transaction_output_test.go

@@ -50,9 +50,9 @@ func TestTransactionOutputCreation(t *testing.T) {
 	}
 	defer gotScript.Destroy()
 
-	scriptData, err := gotScript.Data()
+	scriptData, err := gotScript.Bytes()
 	if err != nil {
-		t.Fatalf("ScriptPubkey.Data() error = %v", err)
+		t.Fatalf("ScriptPubkey.Bytes() error = %v", err)
 	}
 
 	if len(scriptData) != len(scriptBytes) {

kernel/validation_interface_callbacks.go

@@ -47,8 +47,8 @@ func (bp *BlockPointer) GetHash() (*BlockHash, error) {
 	return &BlockHash{ptr: hashPtr}, nil
 }
 
-// CopyData copies the block data into a byte array
-func (bp *BlockPointer) CopyData() ([]byte, error) {
+// Bytes returns the serialized block
+func (bp *BlockPointer) Bytes() ([]byte, error) {
 	if bp.ptr == nil {
 		return nil, ErrBlockUninitialized
 	}

kernel/validation_interface_callbacks_test.go

@@ -15,7 +15,7 @@ func TestValidationInterfaceCallbacks(t *testing.T) {
 			blockCheckedCalled = true
 			lastValidationMode = state.ValidationMode()
 			var err error
-			lastBlockData, err = block.CopyData()
+			lastBlockData, err = block.Bytes()
 			if err != nil {
 				t.Fatal(err)
 			}