Reorganize errors.go by Go struct categories

stringintech · stringintech · commit d905aa7136c0 · 2025-08-23T23:14:55.000+03:30
diff --git a/kernel/block_spent_outputs.go b/kernel/block_spent_outputs.go
@@ -26,7 +26,7 @@ func (bso *BlockSpentOutputs) GetTransactionSpentOutputsAt(index uint64) (*Trans
 	checkReady(bso)
 	ptr := C.btck_block_spent_outputs_get_transaction_spent_outputs_at(bso.ptr, C.uint64_t(index))
 	if ptr == nil {
-		return nil, ErrBlockSpentOutputsGetTransactionSpentOutputsAt
+		return nil, ErrKernelBlockSpentOutputsGetTransactionSpentOutputsAt
 	}
 
 	txSpentOutputs := &TransactionSpentOutputs{ptr: ptr}
diff --git a/kernel/errors.go b/kernel/errors.go
@@ -6,64 +6,78 @@ import (
 )
 
 var (
-	ErrBlockUninitialized                    = &UninitializedError{ObjectName: "block"}
-	ErrBlockHashUninitialized                = &UninitializedError{ObjectName: "blockHash"}
-	ErrBlockTreeEntryUninitialized           = &UninitializedError{ObjectName: "blockTreeEntry"}
-	ErrScriptPubkeyUninitialized             = &UninitializedError{ObjectName: "scriptPubkey"}
-	ErrBlockSpentOutputsUninitialized        = &UninitializedError{ObjectName: "blockSpentOutputs"}
-	ErrTransactionSpentOutputsUninitialized  = &UninitializedError{ObjectName: "transactionSpentOutputs"}
-	ErrCoinUninitialized                     = &UninitializedError{ObjectName: "coin"}
-	ErrTransactionOutputUninitialized        = &UninitializedError{ObjectName: "transactionOutput"}
-	ErrChainUninitialized                    = &UninitializedError{ObjectName: "chain"}
-	ErrChainstateManagerUninitialized        = &UninitializedError{ObjectName: "chainstateManager"}
-	ErrContextUninitialized                  = &UninitializedError{ObjectName: "context"}
-	ErrChainParametersUninitialized          = &UninitializedError{ObjectName: "chainParameters"}
-	ErrContextOptionsUninitialized           = &UninitializedError{ObjectName: "contextOptions"}
+	ErrBlockUninitialized        = &UninitializedError{ObjectName: "block"}
+	ErrKernelBlockCreate         = &KernelError{Operation: "btck_block_create"}
+	ErrKernelBlockCopy           = &KernelError{Operation: "btck_block_copy"}
+	ErrKernelBlockGetHash        = &KernelError{Operation: "btck_block_get_hash"}
+	ErrKernelBlockGetTransaction = &KernelError{Operation: "btck_block_get_transaction_at"}
+	ErrEmptyBlockData            = errors.New("empty block data") // constructor error
+
+	ErrBlockSpentOutputsUninitialized                      = &UninitializedError{ObjectName: "blockSpentOutputs"}
+	ErrKernelBlockSpentOutputsCopy                         = &KernelError{Operation: "btck_block_spent_outputs_copy"}
+	ErrKernelBlockSpentOutputsGetTransactionSpentOutputsAt = &KernelError{Operation: "btck_block_spent_outputs_get_transaction_spent_outputs_at"}
+
+	ErrBlockTreeEntryUninitialized = &UninitializedError{ObjectName: "blockTreeEntry"}
+
+	ErrBlockHashUninitialized = &UninitializedError{ObjectName: "blockHash"}
+
+	ErrBlockValidationStateUninitialized = &UninitializedError{ObjectName: "blockValidationState"}
+
+	ErrTransactionUninitialized   = &UninitializedError{ObjectName: "transaction"}
+	ErrKernelTransactionCreate    = &KernelError{Operation: "btck_transaction_create"}
+	ErrKernelTransactionCopy      = &KernelError{Operation: "btck_transaction_copy"}
+	ErrKernelTransactionGetOutput = &KernelError{Operation: "btck_transaction_get_output_at"}
+	ErrEmptyTransactionData       = errors.New("empty transaction data") // constructor error
+
+	ErrTransactionOutputUninitialized   = &UninitializedError{ObjectName: "transactionOutput"}
+	ErrKernelTransactionOutputCreate    = &KernelError{Operation: "btck_transaction_output_create"}
+	ErrKernelTransactionOutputCopy      = &KernelError{Operation: "btck_transaction_output_copy"}
+	ErrKernelCopyScriptPubkeyFromOutput = &KernelError{Operation: "btck_transaction_output_copy_script_pubkey"}
+
+	ErrTransactionSpentOutputsUninitialized   = &UninitializedError{ObjectName: "transactionSpentOutputs"}
+	ErrKernelTransactionSpentOutputsCopy      = &KernelError{Operation: "btck_transaction_spent_outputs_copy"}
+	ErrKernelTransactionSpentOutputsGetCoinAt = &KernelError{Operation: "btck_transaction_spent_outputs_get_coin_at"}
+
+	ErrScriptPubkeyUninitialized                 = &UninitializedError{ObjectName: "scriptPubkey"}
+	ErrKernelScriptPubkeyCreate                  = &KernelError{Operation: "btck_script_pubkey_create"}
+	ErrKernelScriptPubkeyCopy                    = &KernelError{Operation: "btck_script_pubkey_copy"}
+	ErrKernelScriptVerify                        = &KernelError{Operation: "btck_verify_script"}
+	ErrKernelScriptVerifyInvalidFlags            = &KernelError{Operation: "btck_verify_script", Detail: "the provided bitfield for the flags was invalid"}
+	ErrKernelScriptVerifyInvalidFlagsCombination = &KernelError{Operation: "btck_verify_script", Detail: "the flags were combined in an invalid way"}
+	ErrKernelScriptVerifySpentOutputsRequired    = &KernelError{Operation: "btck_verify_script", Detail: "the taproot flag was set, so valid spent_outputs have to be provided"}
+	ErrEmptyScriptPubkeyData                     = errors.New("empty script pubkey data") // constructor error
+
+	ErrContextUninitialized = &UninitializedError{ObjectName: "context"}
+	ErrKernelContextCreate  = &KernelError{Operation: "btck_context_create"}
+
+	ErrContextOptionsUninitialized = &UninitializedError{ObjectName: "contextOptions"}
+	ErrKernelContextOptionsCreate  = &KernelError{Operation: "btck_context_options_create"}
+
+	ErrChainstateManagerUninitialized       = &UninitializedError{ObjectName: "chainstateManager"}
+	ErrKernelChainstateManagerCreate        = &KernelError{Operation: "btck_chainstate_manager_create"}
+	ErrKernelChainstateManagerProcessBlock  = &KernelError{Operation: "btck_chainstate_manager_process_block"}
+	ErrKernelImportBlocks                   = &KernelError{Operation: "btck_chainstate_manager_import_blocks"}
+	ErrKernelChainstateManagerReadBlock     = &KernelError{Operation: "btck_block_read"}
+	ErrKernelChainstateManagerReadBlockUndo = &KernelError{Operation: "btck_block_undo_read"}
+
 	ErrChainstateManagerOptionsUninitialized = &UninitializedError{ObjectName: "chainstateManagerOptions"}
-	ErrBlockValidationStateUninitialized     = &UninitializedError{ObjectName: "blockValidationState"}
-	ErrTransactionUninitialized              = &UninitializedError{ObjectName: "transaction"}
-	ErrLoggingConnectionUninitialized        = &UninitializedError{ObjectName: "loggingConnection"}
-
-	ErrKernelBlockCreate                             = &KernelError{Operation: "btck_block_create"}
-	ErrKernelBlockCopy                               = &KernelError{Operation: "btck_block_copy"}
-	ErrKernelBlockGetHash                            = &KernelError{Operation: "btck_block_get_hash"}
-	ErrKernelBlockGetTransaction                     = &KernelError{Operation: "btck_block_get_transaction_at"}
-	ErrKernelScriptPubkeyCreate                      = &KernelError{Operation: "btck_script_pubkey_create"}
-	ErrKernelTransactionOutputCreate                 = &KernelError{Operation: "btck_transaction_output_create"}
-	ErrKernelCopyScriptPubkeyFromOutput              = &KernelError{Operation: "btck_transaction_output_copy_script_pubkey"}
-	ErrKernelTransactionCreate                       = &KernelError{Operation: "btck_transaction_create"}
-	ErrBlockSpentOutputsGetTransactionSpentOutputsAt = &KernelError{Operation: "btck_block_spent_outputs_get_transaction_spent_outputs_at"}
-	ErrKernelTransactionCopy                         = &KernelError{Operation: "btck_transaction_copy"}
-	ErrKernelTransactionGetOutput                    = &KernelError{Operation: "btck_transaction_get_output_at"}
-	ErrKernelScriptPubkeyCopy                        = &KernelError{Operation: "btck_script_pubkey_copy"}
-	ErrKernelTransactionOutputCopy                   = &KernelError{Operation: "btck_transaction_output_copy"}
-	ErrKernelBlockSpentOutputsCopy                   = &KernelError{Operation: "btck_block_spent_outputs_copy"}
-	ErrKernelTransactionSpentOutputsCopy             = &KernelError{Operation: "btck_transaction_spent_outputs_copy"}
-	ErrKernelTransactionSpentOutputsGetCoinAt        = &KernelError{Operation: "btck_transaction_spent_outputs_get_coin_at"}
-	ErrKernelCoinCopy                                = &KernelError{Operation: "btck_coin_copy"}
-	ErrKernelLoggingConnectionCreate                 = &KernelError{Operation: "btck_logging_connection_create"}
-	ErrKernelChainstateManagerCreate                 = &KernelError{Operation: "btck_chainstate_manager_create"}
-	ErrKernelChainstateManagerOptionsCreate          = &KernelError{Operation: "btck_chainstate_manager_options_create"}
-	ErrKernelContextCreate                           = &KernelError{Operation: "btck_context_create"}
-	ErrKernelChainstateManagerReadBlock              = &KernelError{Operation: "btck_block_read"}
-	ErrKernelChainstateManagerReadBlockUndo          = &KernelError{Operation: "btck_block_undo_read"}
-	ErrKernelChainstateManagerProcessBlock           = &KernelError{Operation: "btck_chainstate_manager_process_block"}
-	ErrKernelImportBlocks                            = &KernelError{Operation: "btck_chainstate_manager_import_blocks"}
-	ErrKernelChainParametersCreate                   = &KernelError{Operation: "btck_chain_parameters_create"}
-	ErrKernelContextOptionsCreate                    = &KernelError{Operation: "btck_context_options_create"}
-
-	ErrScriptVerify                        = &KernelError{Operation: "btck_verify_script"}
-	ErrScriptVerifyInvalidFlags            = &KernelError{Operation: "btck_verify_script", Detail: "the provided bitfield for the flags was invalid"}
-	ErrScriptVerifyInvalidFlagsCombination = &KernelError{Operation: "btck_verify_script", Detail: "the flags were combined in an invalid way"}
-	ErrScriptVerifySpentOutputsRequired    = &KernelError{Operation: "btck_verify_script", Detail: "the taproot flag was set, so valid spent_outputs have to be provided"}
+	ErrKernelChainstateManagerOptionsCreate  = &KernelError{Operation: "btck_chainstate_manager_options_create"}
+
+	ErrChainParametersUninitialized = &UninitializedError{ObjectName: "chainParameters"}
+	ErrKernelChainParametersCreate  = &KernelError{Operation: "btck_chain_parameters_create"}
+
+	ErrChainUninitialized = &UninitializedError{ObjectName: "chain"}
+
+	ErrCoinUninitialized = &UninitializedError{ObjectName: "coin"}
+	ErrKernelCoinCopy    = &KernelError{Operation: "btck_coin_copy"}
+
+	ErrLoggingConnectionUninitialized = &UninitializedError{ObjectName: "loggingConnection"}
+	ErrKernelLoggingConnectionCreate  = &KernelError{Operation: "btck_logging_connection_create"}
 
 	ErrInvalidChainType                = errors.New("invalid chain type")
 	ErrInvalidLogLevel                 = errors.New("invalid log level")
 	ErrInvalidLogCategory              = errors.New("invalid log category")
 	ErrInvalidScriptVerifyStatus       = errors.New("invalid script verify status")
-	ErrEmptyBlockData                  = errors.New("empty block data")
-	ErrEmptyScriptPubkeyData           = errors.New("empty script pubkey data")
-	ErrEmptyTransactionData            = errors.New("empty transaction data")
 	ErrNilNotificationCallbacks        = errors.New("nil notification callbacks")
 	ErrNilValidationInterfaceCallbacks = errors.New("nil validation interface callbacks")
 )
diff --git a/kernel/script.go b/kernel/script.go
@@ -83,13 +83,13 @@ const (
 func (s ScriptVerifyStatus) err() error {
 	switch s {
 	case ScriptVerifyErrorInvalidFlags:
-		return ErrScriptVerifyInvalidFlags
+		return ErrKernelScriptVerifyInvalidFlags
 	case ScriptVerifyErrorInvalidFlagsCombination:
-		return ErrScriptVerifyInvalidFlagsCombination
+		return ErrKernelScriptVerifyInvalidFlagsCombination
 	case ScriptVerifyErrorSpentOutputsRequired:
-		return ErrScriptVerifySpentOutputsRequired
+		return ErrKernelScriptVerifySpentOutputsRequired
 	default:
-		return ErrScriptVerify
+		return ErrKernelScriptVerify
 	}
 }
 
diff --git a/kernel/script_test.go b/kernel/script_test.go
@@ -89,8 +89,8 @@ func TestInvalidScripts(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			err := testVerifyScript(t, tt.scriptPubkeyHex, tt.amount, tt.txToHex, tt.inputIndex)
-			if err == nil || !errors.Is(err, ErrScriptVerify) {
-				t.Errorf("testVerifyScript() was expected to fail with error '%v'", ErrScriptVerify)
+			if err == nil || !errors.Is(err, ErrKernelScriptVerify) {
+				t.Errorf("testVerifyScript() was expected to fail with error '%v'", ErrKernelScriptVerify)
 			}
 		})
 	}

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ func (bso BlockSpentOutputs) GetTransactionSpentOutputsAt(index uint64) (Trans`
`26`	`26`	`checkReady(bso)`
`27`	`27`	`ptr := C.btck_block_spent_outputs_get_transaction_spent_outputs_at(bso.ptr, C.uint64_t(index))`
`28`	`28`	`if ptr == nil {`
`29`		`- return nil, ErrBlockSpentOutputsGetTransactionSpentOutputsAt`
	`29`	`+ return nil, ErrKernelBlockSpentOutputsGetTransactionSpentOutputsAt`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`txSpentOutputs := &TransactionSpentOutputs{ptr: ptr}`
Original file line number	Diff line number	Diff line change
`@@ -89,8 +89,8 @@ func TestInvalidScripts(t *testing.T) {`
`89`	`89`	`for _, tt := range tests {`
`90`	`90`	`t.Run(tt.name, func(t *testing.T) {`
`91`	`91`	`err := testVerifyScript(t, tt.scriptPubkeyHex, tt.amount, tt.txToHex, tt.inputIndex)`
`92`		`- if err == nil \|\| !errors.Is(err, ErrScriptVerify) {`
`93`		`- t.Errorf("testVerifyScript() was expected to fail with error '%v'", ErrScriptVerify)`
	`92`	`+ if err == nil \|\| !errors.Is(err, ErrKernelScriptVerify) {`
	`93`	`+ t.Errorf("testVerifyScript() was expected to fail with error '%v'", ErrKernelScriptVerify)`
`94`	`94`	`}`
`95`	`95`	`})`
`96`	`96`	`}`