feat: multi version pg_net including 0.19.5 (#1744)

* feat: multi version pg_net including 0.19.5

* feat: bump ver and add tests

* feat: if file exists, run prestart version switch scripts

* tests: bump version to test

* fix: rm unneeded check and fix err codes for file handling

* chore: bump version for testing

* chore: update versions for release

* Add pg-net nixos test in flake checks output

* Move switch_pg_net_version script into separate package

* Fix shellcheck errors

* feat:
limit using verison in extension creation to admin user for all extensions
by using supautils and before-create hooks
add test for this in pg_net

* feat(pg_net): switch version on file system using overlayfs

For pg_net background worker, we need to switch the version of the
extension on the file system (both pg_net.so and pg_net.control need to point
to the desired version).

As the extension is in the Nix store, we cannot simply symlink to the
desired version, as the Nix store is read-only. 
To work around this, we use overlayfs to create a writable layer on top
of the pg_net store path.

* Revert "feat:"

This reverts commit 268cadb.

* fix: fmt

* chore: bump version for testin

* fix: control files need module_pathname

* Revert "fix: control files need module_pathname"

This reverts commit 4996d81.

This change would not resolve the issue it was targeting.

* chore: version bump for testing

* fix: limit flag to versions less than 0.19.1

* chore: bump version for release

---------

Co-authored-by: Jean-François Roche <[email protected]>

Author: samrose

.gitignore

@@ -19,7 +19,7 @@ result*
 .history
 .envrc
 .direnv
-
+.nixos-test-history
 
 #IDE
 .idea/
@@ -30,3 +30,4 @@ common-nix.vars.pkr.hcl
 
 # pre-commit config is managed in nix
 .pre-commit-config.yaml
+nixos.qcow2

ansible/files/postgres_prestart.sh.j2

@@ -1,5 +1,11 @@
 #!/bin/bash
 
+set -x  # Print commands
+
+log() {
+    echo "[$(date '+%Y-%m-%d %H:%M:%S')] $1"
+}
+
 check_orioledb_enabled() {
    local pg_conf="/etc/postgresql/postgresql.conf"
    if [ ! -f "$pg_conf" ]; then
@@ -26,7 +32,87 @@ update_orioledb_buffers() {
    fi
 }
 
+check_extensions_file() {
+    local extensions_file="/etc/adminapi/pg-extensions.json"
+    if [ ! -f "$extensions_file" ]; then
+        log "extensions: No extensions file found, skipping extensions versions check"
+        return 0 #if file not found, skip
+    fi
+    if [ ! -r "$extensions_file" ]; then
+        log "extensions: Cannot read extensions file"
+        return 1 #a true error, we should be able to read file
+    fi
+    return 0
+}
+
+switch_extension_version() {
+    local extension_name="$1"
+    local version="$2"
+    
+    # Use BIN_PATH environment variable or default to /var/lib/postgresql/.nix-profile
+    : ${BIN_PATH:="/var/lib/postgresql/.nix-profile"}
+    
+    local switch_script="$BIN_PATH/bin/switch_${extension_name}_version"
+
+    if [ ! -x "$switch_script" ]; then
+        log "$extension_name: No version switch script available at $switch_script, skipping"
+        return 0
+    fi
+
+    log "$extension_name: Switching to version $version"
+    # Run directly as root since we're already running as root
+    "$switch_script" "$version"
+    local exit_code=$?
+    if [ $exit_code -eq 0 ]; then
+        log "$extension_name: Version switch completed successfully"
+    else
+        log "$extension_name: Version switch failed with exit code $exit_code"
+    fi
+    return $exit_code
+}
+
+handle_extension_versions() {
+    if ! check_extensions_file; then
+        return
+    fi
+
+    local extensions_file="/etc/adminapi/pg-extensions.json"
+    
+    # Get all extension names from the JSON file
+    local extensions
+    extensions=$(jq -r 'keys[]' "$extensions_file" 2>/dev/null)
+    
+    if [ -z "$extensions" ]; then
+        log "extensions: No extensions found in configuration"
+        return
+    fi
+    
+    # Iterate through each extension
+    while IFS= read -r extension_name; do
+        # Get the version for this extension
+        local version
+        version=$(jq -r --arg ext "$extension_name" '.[$ext] // empty' "$extensions_file")
+        
+        if [ -z "$version" ]; then
+            log "$extension_name: No version specified, skipping"
+            continue
+        fi
+                
+        log "$extension_name: Found version $version in extensions file"
+        
+        # Don't fail if version switch fails - just log and continue
+        switch_extension_version "$extension_name" "$version" || log "$extension_name: Version switch failed but continuing"
+        
+    done <<< "$extensions"
+}
+
 main() {
+   log "Starting prestart script"
+   
+   # 1. Handle all extension versions from config file
+   handle_extension_versions
+
+   # 2. orioledb handling 
    local has_orioledb=$(check_orioledb_enabled)
    if [ "$has_orioledb" -lt 1 ]; then
        return 0
@@ -35,6 +121,8 @@ main() {
    if [ ! -z "$shared_buffers_value" ]; then
        update_orioledb_buffers "$shared_buffers_value"
    fi
+
+   log "Prestart script completed"
 }
 
 # Initial locale setup
@@ -46,4 +134,4 @@ if [ $(locale -a | grep -c en_US.utf8) -eq 0 ]; then
    locale-gen
 fi
 
-main
+main

ansible/vars.yml

@@ -9,9 +9,9 @@ postgres_major:
 
 # Full version strings for each major version
 postgres_release:
-  postgresorioledb-17: "17.5.1.017-orioledb"
-  postgres17: "17.4.1.074"
-  postgres15: "15.8.1.131"
+  postgresorioledb-17: "17.5.1.018-orioledb"
+  postgres17: "17.4.1.075"
+  postgres15: "15.8.1.132"
 
 # Non Postgres Extensions
 pgbouncer_release: "1.19.0"

nix/checks.nix

@@ -309,6 +309,10 @@
             ;
         }
         // pkgs.lib.optionalAttrs (system == "x86_64-linux") {
+          pg_net = import ./ext/tests/pg_net.nix {
+            inherit self;
+            inherit pkgs;
+          };
           wrappers = import ./ext/tests/wrappers.nix {
             inherit self;
             inherit pkgs;