Skip to content
This repository was archived by the owner on Oct 9, 2025. It is now read-only.

Conversation

@avallete
Copy link
Member

What kind of change does this PR introduce?

  • Update tests snapshots
  • Include types tests within the runtime tests and inline more for better readability between what's tested and the expected results.
  • Rename all runtime tests *.test.ts
  • Refactor some of the tests types to deduplicate and split them up in files by scope of what's tested.
  • Split down large tests into smaller units
  • Use testSequencer to ensure tests are always run in the same order (since the "write" tests side-effect the other results otherwise).

@avallete avallete marked this pull request as ready for review July 17, 2025 16:55
@avallete avallete requested a review from soedirgo July 17, 2025 17:02
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this test disappear?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, those were used to reproduce an issue (now fixed) and are actually all covered in other places (json selector, ...)

@soedirgo
Copy link
Member

  • Update tests snapshots
  • Include types tests within the runtime tests and inline more for better readability between what's tested and the expected results.
  • Rename all runtime tests *.test.ts
  • Refactor some of the tests types to deduplicate and split them up in files by scope of what's tested.
  • Split down large tests into smaller units
  • Use testSequencer to ensure tests are always run in the same order (since the "write" tests side-effect the other results otherwise).

Can we split these into separate PRs? This is a bit difficult to review

@avallete
Copy link
Member Author

Can we split these into separate PRs? This is a bit difficult to review

Yup, can do, started by merging both the shared types/runtime tests together into the same one to reduce context switching here: #622

Will sequence the rest to minimize diffs for easier reviews.

@avallete avallete closed this Jul 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants