Svelte-check tool outputs wrong line number in machine-verbose mode

[junajan]

Describe the bug

Hello all!

When I use svelte-check command with --output machine vs --output machine-verbose it returns different line numbers.

The reason for this is that here it returns:

• machine mode:

this.log(`${type} ${fn} ${start.line + 1}:${start.character + 1} ${msg}`);
// line and character numbers are being incremented by one

• vs in machine-verbose mode does this:

this.log(
    JSON.stringify({
        type,
        filename,
        start,
        end,
        message,
        code,
        codeDescription,
        source
    })
);
// it returns start and end numbers without incrementing them

Should it be consistent?

Reproduction

just run it for any project with errors/warnings

Expected behaviour

It should output same line number in machine and machine-verbose mode.

System Info

macos

Which package is the issue about?

No response

Additional Information, eg. Screenshots

No response

[jasonlyu123]

0-based line numbers and 1-based line numbers are both widely used. In our internal code, it's zero-based, but for humans to read, it's usually 1-based. It probably is just an oversight in the design, or it was designed to be close to the internal implementation. But either way, we can't change it now because it's a breaking change. What we can probably do is to document the difference.