Avoid using wl_display_dispatch #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wl_display_dispatch is a convenience function intended to poll the socket and wait for events to be dispatched, and may block indefinitely. This function is primarily intended for simple clients that do not use event loops. swayidle uses wl_event_loop to monitor the display socket, and only calls the event handler if there is something to read. Instead of polling again and possibly blocking, read whatever is available directly. Fixes: swaywm#193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wl_display_dispatch is a convenience function intended to poll the socket and wait for events to be dispatched, and may block indefinitely. This function is primarily intended for simple clients that do not use event loops.
swayidle uses wl_event_loop to monitor the display socket, and only calls the event handler if there is something to read. Instead of polling again and possibly blocking, read whatever is available directly.
Fixes: #193
Alternative to: #196
(I don't have a reproduction of the original issue.)