chore: remove unconditioned instrument code

Author: stormslowly

bindings/binding_core_node/src/lib.rs

@@ -58,7 +58,6 @@ pub struct JsCompiler {
 impl JsCompiler {
     #[napi(constructor)]
     #[allow(clippy::new_without_default)]
-    #[tracing::instrument(level = "info", skip_all)]
     pub fn new() -> Self {
         Self {
             _compiler: COMPILER.clone(),

crates/swc/src/lib.rs

@@ -465,7 +465,6 @@ impl Compiler {
         }
     }
 
-    #[tracing::instrument(skip_all)]
     pub fn read_config(&self, opts: &Options, name: &FileName) -> Result<Option<Config>, Error> {
         static CUR_DIR: Lazy<PathBuf> = Lazy::new(|| {
             if cfg!(target_arch = "wasm32") {
@@ -577,7 +576,6 @@ impl Compiler {
     /// This method handles merging of config.
     ///
     /// This method does **not** parse module.
-    #[tracing::instrument(skip_all)]
     pub fn parse_js_as_input<'a, P>(
         &'a self,
         fm: Lrc<SourceFile>,
@@ -642,7 +640,6 @@ impl Compiler {
         })
     }
 
-    #[tracing::instrument(skip_all)]
     pub fn transform(
         &self,
         handler: &Handler,
@@ -670,7 +667,6 @@ impl Compiler {
     ///
     /// This means, you can use `noop_visit_type`, `noop_fold_type` and
     /// `noop_visit_mut_type` in your visitor to reduce the binary size.
-    #[tracing::instrument(skip_all)]
     pub fn process_js_with_custom_pass<P1, P2>(
         &self,
         fm: Arc<SourceFile>,
@@ -727,7 +723,6 @@ impl Compiler {
         })
     }
 
-    #[tracing::instrument(skip(self, handler, opts))]
     pub fn process_js_file(
         &self,
         fm: Arc<SourceFile>,
@@ -745,7 +740,6 @@ impl Compiler {
         )
     }
 
-    #[tracing::instrument(skip_all)]
     pub fn minify(
         &self,
         fm: Arc<SourceFile>,
@@ -938,7 +932,6 @@ impl Compiler {
     /// You can use custom pass with this method.
     ///
     /// Pass building logic has been inlined into the configuration system.
-    #[tracing::instrument(skip_all)]
     pub fn process_js(
         &self,
         handler: &Handler,
@@ -959,7 +952,6 @@ impl Compiler {
         )
     }
 
-    #[tracing::instrument(name = "swc::Compiler::apply_transforms", skip_all)]
     fn apply_transforms(
         &self,
         handler: &Handler,
@@ -1124,7 +1116,6 @@ fn find_swcrc(path: &Path, root: &Path, root_mode: RootMode) -> Option<PathBuf>
     None
 }
 
-#[tracing::instrument(skip_all)]
 fn load_swcrc(path: &Path) -> Result<Rc, Error> {
     let content = read_to_string(path).context("failed to read config (.swcrc) file")?;
 

crates/swc/src/plugin.rs

@@ -91,7 +91,6 @@ impl RustPlugins {
         .with_context(|| format!("failed to invoke plugin on '{filename:?}'"))
     }
 
-    #[tracing::instrument(level = "info", skip_all, name = "apply_plugins")]
     #[cfg(all(feature = "plugin", not(target_arch = "wasm32")))]
     fn apply_inner(&mut self, n: Program) -> Result<Program, anyhow::Error> {
         use anyhow::Context;
@@ -167,7 +166,6 @@ impl RustPlugins {
     }
 
     #[cfg(all(feature = "plugin", target_arch = "wasm32"))]
-    #[tracing::instrument(level = "info", skip_all)]
     fn apply_inner(&mut self, n: Program) -> Result<Program, anyhow::Error> {
         // [TODO]: unimplemented
         n

crates/swc_cli_impl/src/commands/compile.rs

@@ -126,7 +126,6 @@ static DEFAULT_EXTENSIONS: &[&str] = &["js", "jsx", "es6", "es", "mjs", "ts", "t
 /// Infer list of files to be transformed from cli arguments.
 /// If given input is a directory, it'll traverse it and collect all supported
 /// files.
-#[tracing::instrument(level = "info", skip_all)]
 fn get_files_list(
     raw_files_input: &[PathBuf],
     extensions: &[String],

crates/swc_common/src/plugin/serialized.rs

@@ -47,7 +47,6 @@ impl PluginSerializedBytes {
      * Constructs an instance from already serialized byte
      * slices.
      */
-    #[tracing::instrument(level = "info", skip_all)]
     pub fn from_bytes(field: Vec<u8>) -> PluginSerializedBytes {
         PluginSerializedBytes { field }
     }
@@ -59,7 +58,6 @@ impl PluginSerializedBytes {
      * to implement TryFrom trait
      */
     /*
-    #[tracing::instrument(level = "info", skip_all)]
     pub fn try_serialize<W>(t: &VersionedSerializable<W>) -> Result<Self, Error>
     where
         W: rkyv::Serialize<rkyv::ser::serializers::AllocSerializer<512>>,
@@ -78,7 +76,6 @@ impl PluginSerializedBytes {
     }
      */
 
-    #[tracing::instrument(level = "info", skip_all)]
     pub fn try_serialize<W>(t: &VersionedSerializable<W>) -> Result<Self, Error>
     where
         W: cbor4ii::core::enc::Encode,
@@ -93,7 +90,6 @@ impl PluginSerializedBytes {
     /*
      * Internal fn to constructs an instance from raw bytes ptr.
      */
-    #[tracing::instrument(level = "info", skip_all)]
     #[allow(clippy::not_unsafe_ptr_arg_deref)]
     pub fn from_raw_ptr(
         raw_allocated_ptr: *const u8,
@@ -113,7 +109,6 @@ impl PluginSerializedBytes {
         (self.field.as_ptr(), self.field.len())
     }
 
-    #[tracing::instrument(level = "info", skip_all)]
     pub fn deserialize<W>(&self) -> Result<VersionedSerializable<W>, Error>
     where
         W: for<'de> cbor4ii::core::dec::Decode<'de>,
@@ -127,7 +122,6 @@ impl PluginSerializedBytes {
     }
 
     /*
-    #[tracing::instrument(level = "info", skip_all)]
     pub fn deserialize<W>(&self) -> Result<VersionedSerializable<W>, Error>
     where
         W: rkyv::Archive,

crates/swc_core/tests/fixture/stub_napi/src/lib.rs

@@ -41,7 +41,6 @@ pub struct JsCompiler {
 impl JsCompiler {
     #[napi(constructor)]
     #[allow(clippy::new_without_default)]
-    #[tracing::instrument(level = "info", skip_all)]
     pub fn new() -> Self {
         Self {
             _compiler: COMPILER.clone(),

crates/swc_ecma_codegen/src/lib.rs

@@ -1429,7 +1429,6 @@ impl MacroNode for Program {
 
 #[node_impl]
 impl MacroNode for Module {
-    #[tracing::instrument(level = "debug", skip_all)]
     fn emit(&mut self, emitter: &mut Macro) -> Result {
         emitter.emit_leading_comments_of_span(self.span(), false)?;
 
@@ -1457,7 +1456,6 @@ impl MacroNode for Module {
 
 #[node_impl]
 impl MacroNode for Script {
-    #[tracing::instrument(level = "debug", skip_all)]
     fn emit(&mut self, emitter: &mut Macro) -> Result {
         emitter.emit_leading_comments_of_span(self.span(), false)?;
 

crates/swc_ecma_compat_es2015/src/destructuring.rs

@@ -1148,7 +1148,6 @@ fn make_ref_ident(c: Config, decls: &mut Vec<VarDeclarator>, init: Option<Box<Ex
     make_ref_ident_for_array(c, decls, init, None)
 }
 
-#[tracing::instrument(level = "debug", skip_all)]
 fn make_ref_ident_for_array(
     c: Config,
     decls: &mut Vec<VarDeclarator>,

crates/swc_ecma_compat_es2015/src/for_of.rs

@@ -569,7 +569,6 @@ impl ForOf {
 ///     }
 ///   }
 /// ```
-#[tracing::instrument(level = "debug", skip_all)]
 fn make_finally_block(
     iterator_return: Box<Expr>,
     normal_completion_ident: &Ident,

crates/swc_ecma_compat_es2015/src/generator.rs

@@ -978,7 +978,6 @@ impl VisitMut for Generator {
         }
     }
 
-    #[tracing::instrument(level = "debug", skip_all)]
     fn visit_mut_stmt(&mut self, node: &mut Stmt) {
         match node {
             Stmt::Break(b) => {
@@ -3130,7 +3129,6 @@ impl Generator {
         });
     }
 
-    #[tracing::instrument(level = "debug", skip(self))]
     fn try_enter_label(&mut self, op_index: usize) {
         if self.label_offsets.is_none() {
             return;
@@ -3184,7 +3182,6 @@ impl Generator {
     }
 
     /// Tries to enter or leave a code block.
-    #[tracing::instrument(level = "debug", skip(self))]
     fn try_enter_or_leave_block(&mut self, op_index: usize) {
         if let Some(blocks) = &self.blocks {
             while self.block_index < self.block_actions.as_ref().unwrap().len()
@@ -3251,7 +3248,6 @@ impl Generator {
 
     /// Writes an operation as a statement to the current label's statement
     /// list.
-    #[tracing::instrument(level = "debug", skip(self))]
     fn write_operation(&mut self, op_index: usize) {
         if cfg!(debug_assertions) {
             debug!("Writing operation {}", op_index);