Merge branch 'main' into kabir/swift-sdks

Author: kabiroberai

.github/workflows/pull_request.yml

@@ -5,19 +5,6 @@ on:
     types: [opened, reopened, synchronize]
 
 jobs:
-  soundness:
-    name: Soundness
-    uses: swiftlang/github-workflows/.github/workflows/soundness.yml@main
-    with:
-      # Pending https://github.com/swiftlang/vscode-swift/pull/1176
-      license_header_check_enabled: false
-      license_header_check_project_name: "VS Code Swift"
-      api_breakage_check_enabled: false
-      docs_check_enabled: false
-      format_check_enabled: false
-      shell_check_enabled: true
-      unacceptable_language_check_enabled: true
-
   tests:
     name: Test
     uses: swiftlang/github-workflows/.github/workflows/swift_package_test.yml@main
@@ -37,3 +24,16 @@ jobs:
         echo "$NODE_PATH" >> $GITHUB_PATH
       linux_build_command: ./docker/test.sh
       enable_windows_checks: false
+
+  soundness:
+    name: Soundness
+    uses: swiftlang/github-workflows/.github/workflows/soundness.yml@main
+    with:
+      # Pending https://github.com/swiftlang/vscode-swift/pull/1176
+      license_header_check_enabled: false
+      license_header_check_project_name: "VS Code Swift"
+      api_breakage_check_enabled: false
+      docs_check_enabled: false
+      format_check_enabled: false
+      shell_check_enabled: true
+      unacceptable_language_check_enabled: true

assets/test/Swift-Markdown/Package.swift

@@ -0,0 +1,24 @@
+// swift-tools-version:5.6
+// The swift-tools-version declares the minimum version of Swift required to build this package.
+
+import PackageDescription
+
+let package = Package(
+    // FIXME: Can be changed back to Swift-Markdown when
+    // https://github.com/swiftlang/swift-package-manager/issues/7931
+    // is released in the toolchain
+    // NB: The name here needs to match the name of the dependencies under assets/test/dependencies/Package.swift
+    name: "swift-markdown",
+    products: [
+        // Products define the executables and libraries a package produces, making them visible to other packages.
+        .library(
+            name: "PackageLib",
+            targets: ["PackageLib"]),
+    ],
+    targets: [
+        .target(
+            name: "PackageLib",
+            dependencies: []
+        ),
+    ]
+)

assets/test/Swift-Markdown/Sources/PackageLib/PackageLib.swift

@@ -0,0 +1 @@
+public let a = "B"

assets/test/dependencies/Package.swift

@@ -12,7 +12,7 @@ let package = Package(
     targets: [
         .executableTarget(
             name: "dependencies",
-            dependencies: [],
+            dependencies: [.product(name: "PackageLib", package: "Swift-Markdown")],
             path: "Sources"),
     ]
 )

assets/test/dependencies/Sources/main.swift

@@ -1,2 +1,4 @@
+import PackageLib
 
-print("dependencies")
+print("Test Asset:(dependencies)")
+print(a)

package-lock.json

@@ -1309,8 +1309,8 @@
     "@types/sinon-chai": "^3.2.12",
     "@types/vscode": "^1.88.0",
     "@types/xml2js": "^0.4.14",
-    "@typescript-eslint/eslint-plugin": "^8.13.0",
-    "@typescript-eslint/parser": "^8.13.0",
+    "@typescript-eslint/eslint-plugin": "^8.14.0",
+    "@typescript-eslint/parser": "^8.14.0",
     "@vscode/test-cli": "^0.0.10",
     "@vscode/test-electron": "^2.4.1",
     "@vscode/vsce": "^2.32.0",