Fix plugin tasks provider tests

Author: award999

test/integration-tests/tasks/SwiftPluginTaskProvider.test.ts

@@ -14,11 +14,17 @@
 
 import * as vscode from "vscode";
 import * as assert from "assert";
+import { expect } from "chai";
 import { WorkspaceContext } from "../../../src/WorkspaceContext";
 import { folderContextPromise, globalWorkspaceContextPromise } from "../extension.test";
 import { SwiftPluginTaskProvider } from "../../../src/tasks/SwiftPluginTaskProvider";
 import { FolderContext } from "../../../src/FolderContext";
-import { executeTaskAndWaitForResult, mutable, waitForEndTaskProcess } from "../../utilities";
+import {
+    cleanOutput,
+    executeTaskAndWaitForResult,
+    mutable,
+    waitForEndTaskProcess,
+} from "../../utilities";
 
 suite("SwiftPluginTaskProvider Test Suite", () => {
     let workspaceContext: WorkspaceContext;
@@ -27,9 +33,9 @@ suite("SwiftPluginTaskProvider Test Suite", () => {
     suiteSetup(async () => {
         workspaceContext = await globalWorkspaceContextPromise;
         folderContext = await folderContextPromise("command-plugin");
-        assert.notEqual(workspaceContext.folders.length, 0);
+        expect(workspaceContext.folders).to.have.lengthOf(0);
         await folderContext.loadSwiftPlugins();
-        assert.notEqual(folderContext.swiftPackage.plugins.length, 0);
+        expect(workspaceContext.folders).to.not.have.lengthOf(0);
     });
 
     suite("createSwiftPluginTask", () => {
@@ -45,8 +51,8 @@ suite("SwiftPluginTaskProvider Test Suite", () => {
                 scope: folderContext.workspaceFolder,
             });
             const { exitCode, output } = await executeTaskAndWaitForResult(task);
-            assert.equal(exitCode, 0);
-            assert.equal(output.trim(), "Hello, World!");
+            expect(exitCode).to.equal(0);
+            expect(cleanOutput(output)).to.include("Hello, World!");
         }).timeout(10000);
 
         test("Exit code on failure", async () => {
@@ -63,7 +69,7 @@ suite("SwiftPluginTaskProvider Test Suite", () => {
             );
             mutable(task.execution).command = "/definitely/not/swift";
             const { exitCode } = await executeTaskAndWaitForResult(task);
-            assert.notEqual(exitCode, 0);
+            expect(exitCode).to.not.equal(0);
         }).timeout(10000);
     });
 
@@ -77,15 +83,15 @@ suite("SwiftPluginTaskProvider Test Suite", () => {
             });
 
             test("provides", () => {
-                assert.equal(task?.detail, "swift package command_plugin");
+                expect(task?.detail).to.equal("swift package command_plugin");
             });
 
             test("executes", async () => {
                 assert(task);
                 const exitPromise = waitForEndTaskProcess(task);
                 await vscode.tasks.executeTask(task);
                 const exitCode = await exitPromise;
-                assert.equal(exitCode, 0);
+                expect(exitCode).to.equal(0);
             }).timeout(30000); // 30 seconds to run
         });
 
@@ -98,15 +104,15 @@ suite("SwiftPluginTaskProvider Test Suite", () => {
             });
 
             test("provides", () => {
-                assert.equal(task?.detail, "swift package command_plugin --foo");
+                expect(task?.detail).to.equal("swift package command_plugin --foo");
             });
 
             test("executes", async () => {
                 assert(task);
                 const exitPromise = waitForEndTaskProcess(task);
                 await vscode.tasks.executeTask(task);
                 const exitCode = await exitPromise;
-                assert.equal(exitCode, 0);
+                expect(exitCode).to.equal(0);
             }).timeout(30000); // 30 seconds to run
         });
     });

test/utilities.ts

@@ -13,6 +13,8 @@
 //===----------------------------------------------------------------------===//
 
 import * as vscode from "vscode";
+// eslint-disable-next-line @typescript-eslint/no-require-imports
+import stripAnsi = require("strip-ansi");
 import { SwiftTaskFixture } from "./fixtures";
 import { SwiftTask } from "../src/tasks/SwiftTaskProvider";
 
@@ -130,3 +132,14 @@ export function waitForEndTaskProcess(task: vscode.Task): Promise<number | undef
         );
     });
 }
+
+/**
+ * Cleans the provided output stripping ansi and
+ * cleaning extra whitespace
+ *
+ * @param output
+ * @returns cleaned output
+ */
+export function cleanOutput(output: string) {
+    return stripAnsi(output).trim();
+}