Fixed #85

matyhtf · matyhtf · commit 7616655edd21 · 2014-07-01T17:16:19.000+08:00
diff --git a/swoole.c b/swoole.c
@@ -1182,9 +1182,9 @@ PHP_FUNCTION(swoole_server_handler)
 	}
 	if (ret < 0)
 	{
-		php_error_docref(NULL TSRMLS_CC, E_ERROR, "swoole_server_handler: unkown handler[%s].", ha_name);
+		php_error_docref(NULL TSRMLS_CC, E_ERROR, "Unknown event types[%s]", ha_name);
 	}
-	ZVAL_BOOL(return_value, ret);
+	SW_CHECK_RETURN(ret);
 }
 
 PHP_FUNCTION(swoole_server_on)
@@ -1247,9 +1247,9 @@ PHP_FUNCTION(swoole_server_on)
 	}
 	if (ret < 0)
 	{
-		php_error_docref(NULL TSRMLS_CC, E_ERROR, "swoole_server_on: unkown handler[%s].", ha_name);
+		php_error_docref(NULL TSRMLS_CC, E_ERROR, "Unknown event types[%s]", ha_name);
 	}
-	ZVAL_BOOL(return_value, ret);
+	SW_CHECK_RETURN(ret);
 }
 
 PHP_FUNCTION(swoole_server_close)

Original file line number	Diff line number	Diff line change
`@@ -1182,9 +1182,9 @@ PHP_FUNCTION(swoole_server_handler)`
`1182`	`1182`	`}`
`1183`	`1183`	`if (ret < 0)`
`1184`	`1184`	`{`
`1185`		`- php_error_docref(NULL TSRMLS_CC, E_ERROR, "swoole_server_handler: unkown handler[%s].", ha_name);`
	`1185`	`+ php_error_docref(NULL TSRMLS_CC, E_ERROR, "Unknown event types[%s]", ha_name);`
`1186`	`1186`	`}`
`1187`		`- ZVAL_BOOL(return_value, ret);`
	`1187`	`+ SW_CHECK_RETURN(ret);`
`1188`	`1188`	`}`
`1189`	`1189`
`1190`	`1190`	`PHP_FUNCTION(swoole_server_on)`
`@@ -1247,9 +1247,9 @@ PHP_FUNCTION(swoole_server_on)`
`1247`	`1247`	`}`
`1248`	`1248`	`if (ret < 0)`
`1249`	`1249`	`{`
`1250`		`- php_error_docref(NULL TSRMLS_CC, E_ERROR, "swoole_server_on: unkown handler[%s].", ha_name);`
	`1250`	`+ php_error_docref(NULL TSRMLS_CC, E_ERROR, "Unknown event types[%s]", ha_name);`
`1251`	`1251`	`}`
`1252`		`- ZVAL_BOOL(return_value, ret);`
	`1252`	`+ SW_CHECK_RETURN(ret);`
`1253`	`1253`	`}`
`1254`	`1254`
`1255`	`1255`	`PHP_FUNCTION(swoole_server_close)`