Skip to content

Commit 863c5e4

Browse files
committed
minor #543 Skip XML config tests with Symfony 8.0 (GromNaN)
This PR was merged into the 4.x branch. Discussion ---------- Skip XML config tests with Symfony 8.0 | Q | A | ------------- | --- | Branch? | 4.x | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Related to symfony/symfony#60568 | License | MIT Follow-up: - #541 As soon as we keep support for Symfony 7.4, we must keep the tests on XML config format. Commits ------- 3d3b625 Skip XML config tests with Symfony 8.0
2 parents 7ed2209 + 3d3b625 commit 863c5e4

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

tests/DependencyInjection/XmlMonologExtensionTest.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,19 +11,23 @@
1111

1212
namespace Symfony\Bundle\MonologBundle\Tests\DependencyInjection;
1313

14-
use PHPUnit\Framework\Attributes\Group;
14+
use PHPUnit\Framework\Attributes\IgnoreDeprecations;
1515
use Symfony\Component\Config\FileLocator;
1616
use Symfony\Component\DependencyInjection\ContainerBuilder;
1717
use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
1818

1919
/**
2020
* XML configuration deprecated since Symfony 7.4.
2121
*/
22-
#[Group('legacy')]
22+
#[IgnoreDeprecations]
2323
class XmlMonologExtensionTest extends FixtureMonologExtensionTestCase
2424
{
2525
protected function loadFixture(ContainerBuilder $container, string $fixture)
2626
{
27+
if (!class_exists(XmlFileLoader::class)) {
28+
$this->markTestSkipped('The XML configuration has been removed in Symfony 8.0.');
29+
}
30+
2731
$loader = new XmlFileLoader($container, new FileLocator(__DIR__.'/Fixtures/xml'));
2832
$loader->load($fixture.'.xml');
2933
}

0 commit comments

Comments
 (0)