Skip to content

Commit 9eb768f

Browse files
committed
Remove early abort for NULL values in uiprivTableModelSetCellValue.
We are changing the value, update the row! There are several uses for setting NULL values, IMO all abusing the API for different causes. Fix those API abuses instead: - This will cause one unneeded redraw when clicking on table column buttons as they signal a click through setting NULL. Possibly use a dedicated callback handler for that instead? - This will fix resetting colors to default, as this is signaled through a NULL value.
1 parent 07bf95b commit 9eb768f

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

common/tablemodel.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,6 @@ void uiprivTableModelSetCellValue(uiTableModel *m, int row, int column, const ui
4242
mh = uiprivTableModelHandler(m);
4343
(*(mh->SetCellValue))(mh, m, row, column, value);
4444

45-
// Abort redraw for button columns which signal being clicked
46-
// by setting NULL.
47-
// TODO check if NULL is never a valid value otherwise
48-
if (value == NULL)
49-
return;
50-
5145
uiTableModelRowChanged(m, row);
5246
}
5347

0 commit comments

Comments
 (0)