Skip to content

Commit 7f31884

Browse files
committed
cleanup: make useFlags hooks more stable
We were using values in the dependencies array that would cause new functions from being returned even though we didn't use those values inside the callback.
1 parent fbc1f8f commit 7f31884

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

packages/@headlessui-react/src/hooks/use-flags.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ import { useCallback, useState } from 'react'
33
export function useFlags(initialFlags = 0) {
44
let [flags, setFlags] = useState(initialFlags)
55

6-
let setFlag = useCallback((flag: number) => setFlags(flag), [flags])
6+
let setFlag = useCallback((flag: number) => setFlags(flag), [])
77

8-
let addFlag = useCallback((flag: number) => setFlags((flags) => flags | flag), [flags])
8+
let addFlag = useCallback((flag: number) => setFlags((flags) => flags | flag), [])
99
let hasFlag = useCallback((flag: number) => (flags & flag) === flag, [flags])
10-
let removeFlag = useCallback((flag: number) => setFlags((flags) => flags & ~flag), [setFlags])
11-
let toggleFlag = useCallback((flag: number) => setFlags((flags) => flags ^ flag), [setFlags])
10+
let removeFlag = useCallback((flag: number) => setFlags((flags) => flags & ~flag), [])
11+
let toggleFlag = useCallback((flag: number) => setFlags((flags) => flags ^ flag), [])
1212

1313
return { flags, setFlag, addFlag, hasFlag, removeFlag, toggleFlag }
1414
}

0 commit comments

Comments
 (0)