Fix css refresh on elements added to <body> #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore package-lock.json as it wasn't added previously.
Adding a <link> tag outside the <head> element (in the <body>, for example) causes the following error in the console: "Uncaught DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node." This commit fixes that (at least in Firefox) by using the parentNode of the <link> element to remove it. * Add tests for CSS refreshing in test/css.js * Add test/data/css-refreshing-body.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Is this project still maintained? I made this modification because I need it for a project, but if you can merge it, it would be great.
Basically, adding a tag outside the element (in the , for example)
causes the following error in the console:
"Uncaught DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node."
This commit fixes that (at least in Firefox) by using the parentNode of
the element to remove it.
It also adds tests for CSS refreshing, but not as I would like...
PS: Some tests didn't pass in my machine (the --quiet and --port ones). I don't know why, but it has to do nothing with these modifications.
Anyway... I hope you're doing well, and thank you for your time!