Skip to content

Commit c8dfe57

Browse files
committed
refactor: remove unused plus token regex pattern
Remove TOKEN_PLUS_REGEX and its references from regex definitions and WriteAPI. This token pattern was no longer being used in the codebase and was adding unnecessary complexity to the regex matching logic.
1 parent ede2379 commit c8dfe57

File tree

2 files changed

+4
-13
lines changed

2 files changed

+4
-13
lines changed

src/common/regex-define.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ const EMOJI_PROJECT_PREFIX = "#project/"; // Keep for backward compatibility
2121

2222
// Token regexes for inline items (Unicode-friendly)
2323
export const TOKEN_CONTEXT_REGEX = /@[^ \t#@+\[\]]+/u;
24-
export const TOKEN_PLUS_REGEX = /\+[^ \t#@+\[\]]+/u;
2524

2625
// Format types for prefix generation
2726
export type MetadataFormat = "emoji" | "dataview";

src/dataflow/api/WriteAPI.ts

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,7 @@ import {
2323
import { Events, emit } from "../events/Events";
2424
import { CanvasTaskUpdater } from "../../parsers/canvas-task-updater";
2525
import { rrulestr } from "rrule";
26-
import { localDateStringToTimestamp } from "../../utils/date/date-display-helper";
27-
import {
28-
EMOJI_TAG_REGEX,
29-
TOKEN_CONTEXT_REGEX,
30-
TOKEN_PLUS_REGEX,
31-
} from "@/common/regex-define";
26+
import { EMOJI_TAG_REGEX, TOKEN_CONTEXT_REGEX } from "@/common/regex-define";
3227

3328
/**
3429
* Arguments for creating a task
@@ -479,9 +474,8 @@ export class WriteAPI {
479474
const dvFieldToken2 = `\\[(?:${dvKeysGroup2})\\s*::[^\\]]*\\]`;
480475
const tagToken2 = EMOJI_TAG_REGEX.source;
481476
const atToken2 = TOKEN_CONTEXT_REGEX.source;
482-
const plusToken2 = TOKEN_PLUS_REGEX.source;
483477
const emojiSeg2 = `(?:${baseEmoji2}[^\\n]*)`;
484-
const token2 = `(?:${emojiSeg2}|${dvFieldToken2}|${tagToken2}|${atToken2}|${plusToken2})`;
478+
const token2 = `(?:${emojiSeg2}|${dvFieldToken2}|${tagToken2}|${atToken2})`;
485479
const trailing2 = new RegExp(`(?:\\s+${token2})+$`);
486480
const tm2 = sanitized2.match(trailing2);
487481
const trailingMeta = tm2
@@ -618,10 +612,9 @@ export class WriteAPI {
618612
)}[^\\n\\r]*`;
619613
const tagToken = EMOJI_TAG_REGEX.source;
620614
const atToken = TOKEN_CONTEXT_REGEX.source;
621-
const plusToken = TOKEN_PLUS_REGEX.source;
622615
const emojiSeg = `(?:${baseEmoji}[^\\n]*)`;
623616
// Prefer the wide tokens first so we consume the full trailing segment
624-
const token = `(?:${emojiSeg}|${dvFieldToken}|${projectWideToken}|${atWideToken}|${tagToken}|${atToken}|${plusToken})`;
617+
const token = `(?:${emojiSeg}|${dvFieldToken}|${projectWideToken}|${atWideToken}|${tagToken}|${atToken})`;
625618
const trailing = new RegExp(`(?:\\s+${token})+$`);
626619
const tm = sanitized.match(trailing);
627620

@@ -1275,9 +1268,8 @@ export class WriteAPI {
12751268
const dvFieldToken3 = `\\[(?:${dvKeysGroup3})\\s*::[^\\]]*\\]`;
12761269
const tagToken3 = EMOJI_TAG_REGEX.source;
12771270
const atToken3 = TOKEN_CONTEXT_REGEX.source;
1278-
const plusToken3 = TOKEN_PLUS_REGEX.source;
12791271
const emojiSeg3 = `(?:${baseEmoji3}[^\\n]*)`;
1280-
const token3 = `(?:${emojiSeg3}|${dvFieldToken3}|${tagToken3}|${atToken3}|${plusToken3})`;
1272+
const token3 = `(?:${emojiSeg3}|${dvFieldToken3}|${tagToken3}|${atToken3})`;
12811273
const trailing3 = new RegExp(`(?:\\s+${token3})+$`);
12821274
const tm3 = sanitized3.match(trailing3);
12831275
const trailingMeta2 = tm3

0 commit comments

Comments
 (0)