Update ecmarkup output to align more closely with ecma guidelines #661
+152
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 8, 2025
Member
|
Wish I knew where that draft copyright came from, but this seems fine. |
gesa
commented
Nov 12, 2025
| path.relative(outDir, printStyleLocationOnDisk), | ||
| this.opts.printable ? undefined : 'print', | ||
| ); | ||
| this.addStyle(this.doc.head, path.relative(outDir, printStyleLocationOnDisk), 'print'); |
Member
Author
There was a problem hiding this comment.
Setting print styles to all media makes it hard to compare a given element's appearance between print and screen styles
I will forever continue to chip away at this until we can publish a standard without someone giving me a page of bullet points that need fixing
Includes requiring "committee" metadata
Co-authored-by: Michael Ficarra <[email protected]>
gesa
force-pushed
the
format-alignment
branch
from
bd5a486 to
2d86634
Compare
Co-authored-by: Michael Ficarra <[email protected]>
bakkot
approved these changes
Nov 12, 2025
Member
|
Published in v22.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will forever continue to chip away at this until we can publish a standard without someone giving me a full page of formatting problems that need fixing.
Re the draft copyright: this is not an Ecma copyright. The only copyrights that shall appear on Ecma standards are found on the Ecma website, and they are the default copyright and the alternative copyright statement.