Skip to content

Commit 56e5117

Browse files
committed
Merge branch 'worker-best-practices' of https://github.com/temporalio/documentation into worker-best-practices
2 parents 63e0570 + dc3e62b commit 56e5117

File tree

79 files changed

+7952
-4188
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

79 files changed

+7952
-4188
lines changed

.github/CODEOWNERS

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,8 @@
11
* @temporalio/education
2+
3+
# PM owners of sensitive pages
4+
docs/evaluate/temporal-cloud/pricing.mdx @tlotemporal
5+
docs/evaluate/temporal-cloud/support.mdx @tlotemporal
6+
docs/evaluate/temporal-cloud/sla.mdx @bechols
7+
docs/evaluate/temporal-cloud/limits.mdx @bechols
8+
docs/evaluate/temporal-cloud/service-availability.mdx @bechols

.github/workflows/update-cli-docs.yml

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -59,29 +59,33 @@ jobs:
5959
go-version: '1.22'
6060

6161
- name: Generate CLI docs
62-
working-directory: cli/temporalcli/internal/cmd/gen-docs
62+
working-directory: cli/internal/cmd/gen-docs
6363
run: |
6464
go run .
6565
6666
- name: Publish generated docs to documentation repo
6767
env:
6868
GH_TOKEN: ${{ github.token }}
69+
COMMIT_AUTHOR: ${{ github.event.inputs.commit_author }}
70+
COMMIT_AUTHOR_EMAIL: ${{ github.event.inputs.commit_author_email }}
71+
CLI_RELEASE_TAG: ${{ github.event.inputs.cli_release_tag }}
72+
COMMIT_MESSAGE: ${{ github.event.inputs.commit_message }}
6973
working-directory: docs
7074
run: |
7175
set -ex
7276
73-
git config user.name "${{ github.event.inputs.commit_author }}"
74-
git config user.email "${{ github.event.inputs.commit_author_email }}"
75-
76-
branch_name="update-cli-docs-${{ github.event.inputs.cli_release_tag }}"
77-
git checkout -b $branch_name
78-
cp ../cli/temporalcli/docs/*.mdx docs/cli/
77+
git config user.name "$COMMIT_AUTHOR"
78+
git config user.email "$COMMIT_AUTHOR_EMAIL"
79+
80+
branch_name="update-cli-docs-$CLI_RELEASE_TAG"
81+
git checkout -b "$branch_name"
82+
cp ../cli/dist/docs/*.mdx docs/cli/
7983
git add .
80-
git commit -m "${{ github.event.inputs.commit_message }}"
84+
git commit -m "$COMMIT_MESSAGE"
8185
git push origin "$branch_name"
8286
8387
gh pr create \
8488
--body "Autogenerated PR from https://github.com/temporalio/cli" \
85-
--title "${{ github.event.inputs.commit_message }}" \
89+
--title "$COMMIT_MESSAGE" \
8690
--head "$branch_name" \
8791
--base "main"

.husky/pre-commit

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
yarn run lint && yarn run fix-vale
1+
# yarn run lint && yarn run fix-vale

.prettierrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,5 @@
77
"semi": true,
88
"arrowParens": "always",
99
"bracketSpacing": true,
10-
"overrides": [{ "files": "**/*.{md,mx}", "options": { "parser": "mdx" } }]
10+
"overrides": [{ "files": "**/*.{md,mdx}", "options": { "parser": "mdx" } }]
1111
}

CONTRIBUTING.md

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,37 @@
11
# Contribute to Temporal Documentation Locally
22

3-
1. **Clone the Repository**
3+
1. **Fork the Repository**
4+
Create a fork of this repository.
5+
*This creates a copy of this repository to your github account*
6+
7+
2. **Clone the Repository**
48
Run the following commands in your terminal to clone the repository and navigate into it:
59
```bash
610
git clone https://github.com/YOUR_USERNAME/documentation.git
711
cd documentation
812
```
913

10-
2. **Open the Repository in Your IDE**
14+
3. **Open the Repository in Your IDE**
1115
Open the project in your preferred IDE, such as Visual Studio Code. Locate the `/docs` directory, which contains all the content served on `docs.temporal.io`. Identify the changes you want to make.
1216

13-
3. **Create a New Branch**
17+
4. **Create a New Branch**
1418
If you're creating a pull request, create a new branch and switch to it:
1519
```bash
1620
git checkout -b my-documentation-contribution
1721
```
1822

19-
4. **Follow the Style Guide**
23+
5. **Follow the Style Guide**
2024
Refer to [STYLE.md](./STYLE.md) for the documentation style guidelines.
2125

22-
5. **Preview Your Changes Locally**
26+
6. **Preview Your Changes Locally**
2327
Run the following commands to preview the site locally:
2428
```bash
2529
yarn # Install site dependencies
2630
yarn start # Start the website on a local port
2731
yarn build # Check for build warnings or errors
2832
```
2933

30-
6. **Stage Your Changes**
34+
7. **Stage Your Changes**
3135
Use the following commands to stage and commit your changes:
3236
```bash
3337
git status # Check the status of your changes
@@ -36,7 +40,7 @@
3640
git push origin my-documentation-contribution # Push changes
3741
```
3842

39-
7. **Create a Pull Request**
43+
8. **Create a Pull Request**
4044
- After pushing, GitHub provides a link in the terminal to create a PR. Open the link or navigate to your fork on GitHub.
4145
- Click the option to create a Pull Request (PR).
4246
- Provide a descriptive PR title and explanation.

0 commit comments

Comments
 (0)