From fad946001e4a0db23dabb3286223a797f04bce21 Mon Sep 17 00:00:00 2001 From: roxblnfk Date: Wed, 1 Oct 2025 10:18:37 +0400 Subject: [PATCH 1/3] test: Turn on activity context retry policy test --- tests/Acceptance/Extra/Activity/ActivityInfoTest.php | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/Acceptance/Extra/Activity/ActivityInfoTest.php b/tests/Acceptance/Extra/Activity/ActivityInfoTest.php index 6c955b70..825ff739 100644 --- a/tests/Acceptance/Extra/Activity/ActivityInfoTest.php +++ b/tests/Acceptance/Extra/Activity/ActivityInfoTest.php @@ -22,8 +22,6 @@ public static function retryPolicy( #[Stub('Extra_Activity_ActivityInfo', args: [TestWorkflow::ARG_RETRY_OPTIONS])] WorkflowStubInterface $stub, ): void { - self::markTestSkipped('See https://github.com/temporalio/sdk-php/issues/602'); - $result = $stub->getResult(type: 'array'); self::assertSame([ "initial_interval" => ['seconds' => 1, 'nanos' => 0], From f1aaf5bd991ea8e80813fde55e4832466f4aeb51 Mon Sep 17 00:00:00 2001 From: roxblnfk Date: Wed, 1 Oct 2025 10:23:16 +0400 Subject: [PATCH 2/3] feat: Add retry options to ActivityInfo --- src/Activity/ActivityInfo.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Activity/ActivityInfo.php b/src/Activity/ActivityInfo.php index 68a8f81a..c3e85ee2 100644 --- a/src/Activity/ActivityInfo.php +++ b/src/Activity/ActivityInfo.php @@ -17,6 +17,7 @@ use Temporal\Activity; use Temporal\Client\ActivityCompletionClientInterface; use Temporal\Common\Priority; +use Temporal\Common\RetryOptions; use Temporal\Common\Uuid; use Temporal\Internal\Marshaller\Meta\Marshal; use Temporal\Internal\Marshaller\Type\DateIntervalType; @@ -108,6 +109,9 @@ final class ActivityInfo #[Marshal(name: 'Priority')] public Priority $priority; + #[Marshal(name: 'RetryPolicy')] + public ?RetryOptions $retryOptions = null; + /** * ActivityInfo constructor. */ From be7bdb2642eb741be1c675cbc2f9c5e17ca5279b Mon Sep 17 00:00:00 2001 From: roxblnfk Date: Wed, 1 Oct 2025 10:27:52 +0400 Subject: [PATCH 3/3] test: Add RetryPolicy field into unit tests --- tests/Unit/DTO/ActivityInfoTestCase.php | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/Unit/DTO/ActivityInfoTestCase.php b/tests/Unit/DTO/ActivityInfoTestCase.php index 899fe6f7..bcd4a7bd 100644 --- a/tests/Unit/DTO/ActivityInfoTestCase.php +++ b/tests/Unit/DTO/ActivityInfoTestCase.php @@ -40,6 +40,7 @@ public function testMarshalling(): void 'Priority' => [ 'priority_key' => 0, ], + 'RetryPolicy' => null, ]; $this->assertSame($expected, $this->marshal($dto));