Do not support None context

Author: dandavison

temporalio/converter.py

@@ -139,7 +139,7 @@ class WithSerializationContext(ABC):
     during serialization and deserialization.
     """
 
-    def with_context(self, context: Optional[SerializationContext]) -> Self:
+    def with_context(self, context: SerializationContext) -> Self:
         """Return a copy of this object configured to use the given context.
 
         Args:
@@ -401,7 +401,7 @@ def from_payloads(
                 ) from err
         return values
 
-    def with_context(self, context: Optional[SerializationContext]) -> Self:
+    def with_context(self, context: SerializationContext) -> Self:
         """Return a new instance with the given context."""
         converters = [
             c.with_context(context) if isinstance(c, WithSerializationContext) else c
@@ -1313,12 +1313,13 @@ def _with_context(self, context: Optional[SerializationContext]) -> Self:
         payload_converter = self.payload_converter
         payload_codec = self.payload_codec
         failure_converter = self.failure_converter
-        if isinstance(payload_converter, WithSerializationContext):
-            payload_converter = payload_converter.with_context(context)
-        if isinstance(payload_codec, WithSerializationContext):
-            payload_codec = payload_codec.with_context(context)
-        if isinstance(failure_converter, WithSerializationContext):
-            failure_converter = failure_converter.with_context(context)
+        if context:
+            if isinstance(payload_converter, WithSerializationContext):
+                payload_converter = payload_converter.with_context(context)
+            if isinstance(payload_codec, WithSerializationContext):
+                payload_codec = payload_codec.with_context(context)
+            if isinstance(failure_converter, WithSerializationContext):
+                failure_converter = failure_converter.with_context(context)
         object.__setattr__(cloned, "payload_converter", payload_converter)
         object.__setattr__(cloned, "payload_codec", payload_codec)
         object.__setattr__(cloned, "failure_converter", failure_converter)

temporalio/worker/_workflow_instance.py

@@ -2065,10 +2065,15 @@ def _converters(
         """Construct workflow payload and failure converters with the given context."""
         payload_converter = self._payload_converter_class()
         failure_converter = self._failure_converter_class()
-        if isinstance(payload_converter, temporalio.converter.WithSerializationContext):
-            payload_converter = payload_converter.with_context(context)
-        if isinstance(failure_converter, temporalio.converter.WithSerializationContext):
-            failure_converter = failure_converter.with_context(context)
+        if context:
+            if isinstance(
+                payload_converter, temporalio.converter.WithSerializationContext
+            ):
+                payload_converter = payload_converter.with_context(context)
+            if isinstance(
+                failure_converter, temporalio.converter.WithSerializationContext
+            ):
+                failure_converter = failure_converter.with_context(context)
         return payload_converter, failure_converter
 
     def _instantiate_workflow_object(self) -> Any: