updated bandaid

Author: Shivs11

config/rbac/role.yaml

@@ -0,0 +1,66 @@
+---
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRole
+metadata:
+  name: manager-role
+rules:
+- apiGroups:
+  - ""
+  resources:
+  - secrets
+  verbs:
+  - get
+  - list
+  - watch
+- apiGroups:
+  - apps
+  resources:
+  - deployments
+  verbs:
+  - create
+  - delete
+  - get
+  - list
+  - patch
+  - update
+  - watch
+- apiGroups:
+  - apps
+  resources:
+  - deployments/scale
+  verbs:
+  - update
+- apiGroups:
+  - temporal.io
+  resources:
+  - temporalconnections
+  verbs:
+  - get
+  - list
+  - watch
+- apiGroups:
+  - temporal.io
+  resources:
+  - temporalworkerdeployments
+  verbs:
+  - create
+  - delete
+  - get
+  - list
+  - patch
+  - update
+  - watch
+- apiGroups:
+  - temporal.io
+  resources:
+  - temporalworkerdeployments/finalizers
+  verbs:
+  - update
+- apiGroups:
+  - temporal.io
+  resources:
+  - temporalworkerdeployments/status
+  verbs:
+  - get
+  - patch
+  - update

config/webhook/manifests.yaml

@@ -0,0 +1,26 @@
+---
+apiVersion: admissionregistration.k8s.io/v1
+kind: MutatingWebhookConfiguration
+metadata:
+  name: mutating-webhook-configuration
+webhooks:
+- admissionReviewVersions:
+  - v1
+  clientConfig:
+    service:
+      name: webhook-service
+      namespace: system
+      path: /mutate-temporal-io-temporal-io-v1alpha1-temporalworkerdeployment
+  failurePolicy: Fail
+  name: mtemporalworker.kb.io
+  rules:
+  - apiGroups:
+    - temporal.io.temporal.io
+    apiVersions:
+    - v1alpha1
+    operations:
+    - CREATE
+    - UPDATE
+    resources:
+    - temporalworkers
+  sideEffects: None

internal/planner/planner.go

@@ -339,8 +339,7 @@ func getTestWorkflows(
 	// Skip if there's no gate workflow defined, if the target version is already the current, or if the target
 	// version is not yet registered in temporal
 	if config.RolloutStrategy.Gate == nil ||
-		status.CurrentVersion == nil ||
-		status.CurrentVersion.BuildID == status.TargetVersion.BuildID ||
+		(status.CurrentVersion != nil && status.CurrentVersion.BuildID == status.TargetVersion.BuildID) ||
 		status.TargetVersion.Status == temporaliov1alpha1.VersionStatusNotRegistered {
 		return nil
 	}
@@ -390,7 +389,7 @@ func getVersionConfigDiff(
 	}
 
 	// Do nothing if the test workflows have not completed successfully
-	if strategy.Gate != nil && status.CurrentVersion != nil {
+	if strategy.Gate != nil {
 		if len(status.TargetVersion.TaskQueues) == 0 {
 			return nil
 		}

internal/planner/planner_test.go

@@ -1014,28 +1014,6 @@ func TestGetTestWorkflows(t *testing.T) {
 			},
 			expectWorkflows: 0,
 		},
-		{
-			name: "gate workflow without current version",
-			status: &temporaliov1alpha1.TemporalWorkerDeploymentStatus{
-				TargetVersion: temporaliov1alpha1.TargetWorkerDeploymentVersion{
-					BaseWorkerDeploymentVersion: temporaliov1alpha1.BaseWorkerDeploymentVersion{
-						BuildID: "123",
-						Status:  temporaliov1alpha1.VersionStatusInactive,
-						TaskQueues: []temporaliov1alpha1.TaskQueue{
-							{Name: "queue1"},
-						},
-					},
-				},
-				CurrentVersion: nil,
-			},
-			config: &Config{
-				RolloutStrategy: temporaliov1alpha1.RolloutStrategy{
-					Gate: &temporaliov1alpha1.GateWorkflowConfig{WorkflowType: "TestWorkflow"},
-				},
-			},
-			// should not start gate workflows if current version is not set. This happens when there is no initial deployment version present.
-			expectWorkflows: 0,
-		},
 		{
 			name: "all test workflows already running",
 			status: &temporaliov1alpha1.TemporalWorkerDeploymentStatus{
@@ -1241,9 +1219,18 @@ func TestGetVersionConfigDiff(t *testing.T) {
 						BuildID:      "123",
 						Status:       temporaliov1alpha1.VersionStatusInactive,
 						HealthySince: &metav1.Time{Time: time.Now()},
+						TaskQueues: []temporaliov1alpha1.TaskQueue{
+							{Name: "queue1"},
+						},
+					},
+					TestWorkflows: []temporaliov1alpha1.WorkflowExecution{
+						{
+							TaskQueue: "queue1",
+							Status:    temporaliov1alpha1.WorkflowExecutionStatusCompleted,
+						},
 					},
 				},
-				// CurrentVersion intentionally nil to simulate bootstrap
+				CurrentVersion: nil,
 			},
 			state: &temporal.TemporalWorkerState{
 				Versions: map[string]*temporal.VersionInfo{