Skip to content

Commit b57c9ce

Browse files
committed
Merge remote-tracking branch 'upstream/main' into ss/api-keys
2 parents e518342 + 95221a3 commit b57c9ce

File tree

8 files changed

+373
-79
lines changed

8 files changed

+373
-79
lines changed

Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ help: ## Display this help.
152152
.PHONY: manifests
153153
manifests: controller-gen ## Generate WebhookConfiguration, ClusterRole and CustomResourceDefinition objects.
154154
GOWORK=off GO111MODULE=on $(CONTROLLER_GEN) rbac:roleName=manager-role crd:allowDangerousTypes=true,maxDescLen=0,generateEmbeddedObjectMeta=true webhook paths=./api/... paths=./internal/... paths=./cmd/... \
155-
output:crd:artifacts:config=helm/temporal-worker-controller/templates/crds
155+
output:crd:artifacts:config=helm/temporal-worker-controller/crds
156156

157157
.PHONY: generate
158158
generate: controller-gen ## Generate code containing DeepCopy, DeepCopyInto, and DeepCopyObject method implementations.
@@ -268,11 +268,11 @@ endif
268268

269269
.PHONY: install
270270
install: manifests ## Install CRDs into the K8s cluster specified in ~/.kube/config.
271-
$(KUBECTL) apply --context $(K8S_CONTEXT) -f helm/temporal-worker-controller/templates/crds
271+
$(KUBECTL) apply --context $(K8S_CONTEXT) -f helm/temporal-worker-controller/crds
272272

273273
.PHONY: uninstall
274274
uninstall: manifests ## Uninstall CRDs from the K8s cluster specified in ~/.kube/config. Call with ignore-not-found=true to ignore resource not found errors during deletion.
275-
$(KUBECTL) delete --context $(K8S_CONTEXT) --ignore-not-found=$(ignore-not-found) -f helm/temporal-worker-controller/templates/crds
275+
$(KUBECTL) delete --context $(K8S_CONTEXT) --ignore-not-found=$(ignore-not-found) -f helm/temporal-worker-controller/crds
276276

277277
.PHONY: deploy
278278
deploy: manifests helm ## Deploy controller to the K8s cluster specified in ~/.kube/config.

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,8 @@ When you update the image, the controller automatically:
7474
7575
### Prerequisites
7676
77-
- Kubernetes cluster (1.19+)
77+
- Kubernetes cluster (1.19+)
78+
- Helm [v3.0+](https://github.com/helm/helm/releases) if deploying via our Helm chart
7879
- [Temporal Server](https://docs.temporal.io/) (Cloud or self-hosted [v1.28.1](https://github.com/temporalio/temporal/releases/tag/v1.28.1))
7980
- Basic familiarity with Temporal [Workers](https://docs.temporal.io/workers), [Workflows](https://docs.temporal.io/workflows), and [Worker Versioning](https://docs.temporal.io/production-deployment/worker-deployments/worker-versioning)
8081

docs/configuration.md

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -182,35 +182,6 @@ rollout:
182182
pauseDuration: 5m
183183
gate:
184184
workflowType: "HealthCheck"
185-
input: |
186-
{
187-
"version": "{{.Version}}",
188-
"environment": "production"
189-
}
190-
timeout: 300s
191-
```
192-
193-
### Gate Workflow Examples
194-
195-
**Simple Health Check:**
196-
```yaml
197-
gate:
198-
workflowType: "HealthCheck"
199-
timeout: 60s
200-
```
201-
202-
**Complex Validation with Input:**
203-
```yaml
204-
gate:
205-
workflowType: "ValidationWorkflow"
206-
input: |
207-
{
208-
"deploymentName": "{{.DeploymentName}}",
209-
"buildId": "{{.BuildId}}",
210-
"rampPercentage": {{.RampPercentage}},
211-
"environment": "{{.Environment}}"
212-
}
213-
timeout: 600s
214185
```
215186

216187
## Advanced Configuration
@@ -240,7 +211,6 @@ spec:
240211
pauseDuration: 45m
241212
gate:
242213
workflowType: "ProductionHealthCheck"
243-
timeout: 300s
244214
sunset:
245215
scaledownDelay: 2h
246216
deleteDelay: 48h

helm/temporal-worker-controller/Chart.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@ apiVersion: v2
22
name: temporal-worker-controller
33
description: A Helm chart for the Temporal Worker Controller
44
type: application
5-
version: 0.8.0
6-
appVersion: 1.0.0
5+
version: 0.9.0
6+
appVersion: 1.0.2

internal/tests/internal/env_helpers.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ func setupTestEnvironment(t *testing.T) (*rest.Config, client.Client, manager.Ma
113113
t.Log("bootstrapping test environment")
114114
testEnv := &envtest.Environment{
115115
CRDDirectoryPaths: []string{
116-
filepath.Join(getRepoRoot(t), "helm", "temporal-worker-controller", "templates", "crds"),
116+
filepath.Join(getRepoRoot(t), "helm", "temporal-worker-controller", "crds"),
117117
},
118118
ErrorIfCRDPathMissing: true,
119119
}

0 commit comments

Comments
 (0)