Fix building in Linux glibc with gcc14 and clang19

Author: Biswa96

.github/workflows/build.yml

@@ -3,6 +3,46 @@ name: build
 on: [push, pull_request]
 
 jobs:
+
+  linux:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - os: "archlinux:base"
+            pkgs: "gcc"
+            env: "CC=gcc CXX=g++"
+          - os: "archlinux:base"
+            pkgs: "clang"
+            env: "CC=clang CXX=clang++"
+    container:
+      image: ${{ matrix.os }}
+    steps:
+    - name: prep archlinux
+      if: startsWith(matrix.os, 'archlinux')
+      run: |
+        pacman -Syu --needed --noconfirm \
+          ${{ matrix.pkgs }} bison cmake expat flex fmt git gtest \
+          libpng ninja pkgconf protobuf
+    - name: Checkout
+      uses: actions/checkout@v4
+      with:
+        submodules: true
+    - name: Prepare
+      run: |
+        git config --global user.email "[email protected]"
+        git config --global user.name "Your Name"
+    - name: Build
+      run: |
+        test -n "${{ matrix.env }}" && export ${{ matrix.env }}
+        cmake -B build -G Ninja
+        cmake --build build
+    - name: Check
+      run: |
+        ./build/vendor/aapt version
+        ./build/vendor/aapt2 version
+
   mingw:
     runs-on: windows-latest
     strategy:

patches/base/0003-base-Fix-variable-initialization.patch

@@ -0,0 +1,44 @@
+From 3bea7c9d6f6c7750fcd180f84f5b32c76d35e56e Mon Sep 17 00:00:00 2001
+From: Biswapriyo Nath <[email protected]>
+Date: Wed, 1 Jan 2025 00:00:00 +0000
+Subject: [PATCH] base: Fix variable initialization
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+This fixes the following compiler error with g++
+
+AssetsProvider.cpp:140:18: error: expected primary-expression before ‘.’ token
+  140 |   struct stat sb{.st_mtime = -1};
+      |                  ^
+---
+ libs/androidfw/AssetsProvider.cpp | 6 ++++--
+ 1 file changed, 4 insertions(+), 2 deletions(-)
+
+diff --git a/libs/androidfw/AssetsProvider.cpp b/libs/androidfw/AssetsProvider.cpp
+index 2d3c06506..aeee8dd22 100644
+--- a/libs/androidfw/AssetsProvider.cpp
++++ b/libs/androidfw/AssetsProvider.cpp
+@@ -104,7 +104,8 @@ std::unique_ptr<ZipAssetsProvider> ZipAssetsProvider::Create(std::string path,
+     return {};
+   }
+ 
+-  struct stat sb{.st_mtime = -1};
++  struct stat sb{};
++  sb.st_mtime = -1;
+   // Skip all up-to-date checks if the file won't ever change.
+   if (!isReadonlyFilesystem(path.c_str())) {
+     if ((released_fd < 0 ? stat(path.c_str(), &sb) : fstat(released_fd, &sb)) < 0) {
+@@ -137,7 +138,8 @@ std::unique_ptr<ZipAssetsProvider> ZipAssetsProvider::Create(base::unique_fd fd,
+     return {};
+   }
+ 
+-  struct stat sb{.st_mtime = -1};
++  struct stat sb{};
++  sb.st_mtime = -1;
+   // Skip all up-to-date checks if the file won't ever change.
+   if (!isReadonlyFilesystem(released_fd)) {
+     if (fstat(released_fd, &sb) < 0) {
+-- 
+2.48.1
+

patches/core/0001-core-Workaround-clang-nullability-specifiers.patch

@@ -0,0 +1,28 @@
+From dad694acb458b626445ebd8e220af6d3fbfa3de9 Mon Sep 17 00:00:00 2001
+From: Biswapriyo Nath <[email protected]>
+Date: Wed, 1 Jan 2025 00:00:00 +0000
+Subject: [PATCH] core: Workaround clang nullability specifiers
+
+---
+ libutils/Threads.cpp | 5 +++++
+ 1 file changed, 5 insertions(+)
+
+diff --git a/libutils/Threads.cpp b/libutils/Threads.cpp
+index d8d75ac..5b8ca78 100644
+--- a/libutils/Threads.cpp
++++ b/libutils/Threads.cpp
+@@ -42,6 +42,11 @@
+ # define __android_unused __attribute__((__unused__))
+ #endif
+ 
++#ifndef __clang__
++#define _Nonnull
++#define _Nullable
++#endif
++
+ /*
+  * ===========================================================================
+  *      Thread wrappers
+-- 
+2.48.1
+