Skip to content

Commit 7602165

Browse files
Zheng Qinq2w
authored andcommitted
addressing comment
1 parent cd3ca4f commit 7602165

File tree

6 files changed

+10
-8
lines changed

6 files changed

+10
-8
lines changed

metadata.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,11 @@ spec:
7575
roles:
7676
- level: Project
7777
roles:
78+
- roles/cloudsql.admin
7879
- roles/iam.serviceAccountAdmin
7980
- roles/iam.serviceAccountUser
8081
- roles/resourcemanager.projectIamAdmin
8182
- roles/serviceusage.serviceUsageAdmin
82-
- roles/cloudsql.admin
8383
services:
8484
- cloudresourcemanager.googleapis.com
8585
- iam.googleapis.com

modules/backup/metadata.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,9 +191,9 @@ spec:
191191
roles:
192192
- level: Project
193193
roles:
194-
- roles/logging.logWriter
195194
- roles/cloudsql.admin
196195
- roles/iam.serviceAccountUser
196+
- roles/logging.logWriter
197197
services:
198198
- serviceusage.googleapis.com
199199
- sqladmin.googleapis.com

modules/mysql/metadata.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -918,12 +918,12 @@ spec:
918918
roles:
919919
- level: Project
920920
roles:
921-
- roles/cloudsql.admin
922-
- roles/resourcemanager.projectIamAdmin
923921
- roles/iam.serviceAccountUser
924922
- roles/compute.networkAdmin
925923
- roles/cloudkms.cryptoKeyEncrypterDecrypter
926924
- roles/logging.logWriter
925+
- roles/cloudsql.admin
926+
- roles/resourcemanager.projectIamAdmin
927927
services:
928928
- cloudkms.googleapis.com
929929
- cloudresourcemanager.googleapis.com

modules/postgresql/metadata.yaml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -924,21 +924,22 @@ spec:
924924
roles:
925925
- level: Project
926926
roles:
927+
- roles/cloudkms.admin
928+
- roles/logging.logWriter
927929
- roles/cloudsql.admin
930+
- roles/storage.admin
928931
- roles/resourcemanager.projectIamAdmin
929932
- roles/iam.serviceAccountUser
930933
- roles/compute.networkAdmin
931-
- roles/cloudkms.admin
932934
- roles/cloudkms.autokeyAdmin
933-
- roles/storage.admin
934935
- roles/cloudkms.cryptoKeyEncrypterDecrypter
935-
- roles/logging.logWriter
936936
services:
937937
- cloudkms.googleapis.com
938938
- cloudresourcemanager.googleapis.com
939939
- compute.googleapis.com
940940
- iam.googleapis.com
941941
- monitoring.googleapis.com
942+
- servicenetworking.googleapis.com
942943
- serviceusage.googleapis.com
943944
- sqladmin.googleapis.com
944945
providerVersions:

modules/safer_mysql/metadata.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -384,9 +384,9 @@ spec:
384384
roles:
385385
- level: Project
386386
roles:
387-
- roles/cloudsql.admin
388387
- roles/iam.serviceAccountUser
389388
- roles/logging.logWriter
389+
- roles/cloudsql.admin
390390
services:
391391
- serviceusage.googleapis.com
392392
- sqladmin.googleapis.com

test/setup/main.tf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ locals {
4242
postgresql = [
4343
"sqladmin.googleapis.com",
4444
"serviceusage.googleapis.com",
45+
"servicenetworking.googleapis.com",
4546
"iam.googleapis.com",
4647
"cloudkms.googleapis.com",
4748
"cloudresourcemanager.googleapis.com",

0 commit comments

Comments
 (0)