fix: extract out worker_pool logic #819

iamar7 · 2025-10-15T09:48:46Z

Description

Issue: https://github.ibm.com/GoldenEye/issues/issues/16090

Release required?

No release
Patch release (x.x.X)
Minor release (x.X.x)
Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

If relevant, a test for the change is included or updated with this PR.
If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

…form-ibm-base-ocp-vpc into 16090-cds

iamar7 · 2025-10-15T10:50:43Z

/run pipeline

…terraform-ibm-base-ocp-vpc into 16090-cds

iamar7 · 2025-10-16T10:10:42Z

/run pipeline

iamar7 · 2025-10-17T13:55:33Z

/run pipeline

toddgiguere · 2025-10-17T17:43:05Z

Changes look good, but while we are making changes there is an incorrect ImplicitDestroy address in one the tests, can we fix this in the PR?

TestRunCustomsgExample 2025-10-17T14:59:25Z tests.go:157: ╷
│ Error: Invalid target address
│ 
│ No matching objects found. To view the available instances, use "terraform
│ state list". Please modify the address to reference a specific instance.

iamar7 · 2025-10-21T07:26:53Z

/run pipeline

iamar7 · 2025-10-21T14:08:54Z

/run pipeline

iamar7 · 2025-10-21T15:04:17Z

/run pipeline

iamar7 · 2025-10-22T07:51:40Z

/run pipeline

iamar7 · 2025-10-24T19:54:39Z

/run pipeline

…terraform-ibm-base-ocp-vpc into 16090-cds

iamar7 · 2025-10-28T11:29:20Z

/run pipeline

ocofaigh · 2025-10-28T16:24:33Z

The test failed with:

│ Error: ---
│ id: terraform-74ff8d5a
│ summary: 'DeleteSecurityGroupTargetBindingWithContext failed: The load balancer with
│   ID ''r018-bb5a2818-e8da-41dd-b428-123c41838945'' cannot be updated because its status
│   is ''UPDATE_PENDING''.'
│ severity: error
│ resource: ibm_is_security_group_target
│ operation: delete
│ component:
│   name: github.com/IBM-Cloud/terraform-provider-ibm
│   version: 1.84.3
│ ---

Unrelated to changes in this PR so retrying..

ocofaigh · 2025-10-28T16:24:43Z

/run pipeline

iamar7 · 2025-10-28T17:56:14Z

/run pipeline

iamar7 · 2025-10-29T05:46:08Z

/run pipeline

iamar7 · 2025-10-29T09:20:21Z

TestRunQuickstartSchematics is failing with this

  2025/10/29 05:57:21 Terraform plan | Error: Invalid value for variable
         2025/10/29 05:57:21 Terraform plan |           + resolution_binding_count = (known after apply)
         2025/10/29 05:57:21 Terraform plan | 
         2025/10/29 05:57:21 Terraform plan |           + resolver (known after apply)
         2025/10/29 05:57:21 Terraform plan |         }
         2025/10/29 05:57:21 Terraform plan |     }
         2025/10/29 05:57:21 Terraform plan |   on main.tf line 142, in module "ocp_base":
         2025/10/29 05:57:21 Terraform plan |  142:   worker_pools                        = local.worker_pools
         2025/10/29 05:57:21 Terraform plan |     ├────────────────
         2025/10/29 05:57:21 Terraform plan |     │ local.ocp_version_num is "4.19"
         2025/10/29 05:57:21 Terraform plan |     │ local.os_rhcos is "RHCOS"
         2025/10/29 05:57:21 Terraform plan |     │ local.os_rhel is "REDHAT_8_64"
         2025/10/29 05:57:21 Terraform plan |     │ local.os_rhel9 is "RHEL_9_64"
         2025/10/29 05:57:21 Terraform plan |     │ var.worker_pools is list of object with 1 element
         2025/10/29 05:57:21 Terraform plan | 
         2025/10/29 05:57:21 Terraform plan | Invalid operating system for the given OCP version. Ensure the OS is
         2025/10/29 05:57:21 Terraform plan | compatible with the OCP version. Supported compatible OCP version and OS are
         2025/10/29 05:57:21 Terraform plan | v4.14: (REDHAT_8_64); v4.15: (REDHAT_8_64, RHCOS) ; v4.16 and v4.17:
         2025/10/29 05:57:21 Terraform plan | (REDHAT_8_64, RHCOS, RHEL_9_64); v4.18: (RHCOS, RHEL_9_64)

TestRunQuickstartUpgradeSchematics is failing with the following error:

   2025/10/29 05:57:13 Terraform plan |  142:   worker_pools                        = local.worker_pools
      2025/10/29 05:57:13 Terraform plan |     ├────────────────
      2025/10/29 05:57:13 Terraform plan |     │ local.ocp_version_num is "4.19"
      2025/10/29 05:57:13 Terraform plan |     │ local.os_rhcos is "RHCOS"
      2025/10/29 05:57:13 Terraform plan |     │ local.os_rhel is "REDHAT_8_64"
      2025/10/29 05:57:13 Terraform plan |     │ local.os_rhel9 is "RHEL_9_64"
      2025/10/29 05:57:13 Terraform plan |     │ var.worker_pools is list of object with 1 element
      2025/10/29 05:57:13 Terraform plan | 
      2025/10/29 05:57:13 Terraform plan | Invalid operating system for the given OCP version. Ensure the OS is
      2025/10/29 05:57:13 Terraform plan | compatible with the OCP version. Supported compatible OCP version and OS are
      2025/10/29 05:57:13 Terraform plan | v4.14: (REDHAT_8_64); v4.15: (REDHAT_8_64, RHCOS) ; v4.16 and v4.17:
      2025/10/29 05:57:13 Terraform plan | (REDHAT_8_64, RHCOS, RHEL_9_64); v4.18: (RHCOS, RHEL_9_64)
      2025/10/29 05:57:13 Terraform plan | 
      2025/10/29 05:57:13 Terraform plan | This was checked by the validation rule at ../../variables.tf:104,3-13.
      2025/10/29 05:57:13 Terraform PLAN error: Terraform PLAN errorexit status 1
      
      2025/10/29 05:57:13 -----  Terraform SHOW  -----
      
      2025/10/29 05:57:13 Starting command: terraform1.10 show -no-color -json tfplan.binary
      2025/10/29 05:57:13 Starting command: terraform1.10 show -no-color -json tfplan.binary
      2025/10/29 05:57:18 Command finished successfully.
      2025/10/29 05:57:18 Could not execute job: Error : Terraform PLAN errorexit status 1
     
     =============== END PLAN JOB LOG (eu-de.workspace.ocp-qs-upg-mw3.caf8f19f) ===============
 tests.go:505: [SCHEMATICS] Removing temp directory for upgrade test: /tmp/terraform-base-ocp-qs-upg-mw33828669995
--- FAIL: TestRunQuickstartUpgradeSchematics (240.74s)

These failures will be resolved as part of this PR: #840

iamar7 · 2025-10-29T09:20:55Z

TestRunCustomsgExample is failing with this:

TestRunCustomsgExample 2025-10-29T06:50:51Z command.go:212: │ Error: ---
TestRunCustomsgExample 2025-10-29T06:50:51Z command.go:212: │ id: terraform-74ff8d5a
TestRunCustomsgExample 2025-10-29T06:50:51Z command.go:212: │ summary: 'DeleteSecurityGroupTargetBindingWithContext failed: The load balancer with
TestRunCustomsgExample 2025-10-29T06:50:51Z command.go:212: │   ID ''r042-bff8eeb7-4374-43a0-961c-4cf5149e2072'' cannot be updated because its status
TestRunCustomsgExample 2025-10-29T06:50:51Z command.go:212: │   is ''UPDATE_PENDING''.'
TestRunCustomsgExample 2025-10-29T06:50:51Z command.go:212: │ severity: error
TestRunCustomsgExample 2025-10-29T06:50:51Z command.go:212: │ resource: ibm_is_security_group_target
TestRunCustomsgExample 2025-10-29T06:50:51Z command.go:212: │ operation: delete
TestRunCustomsgExample 2025-10-29T06:50:51Z command.go:212: │ component:
TestRunCustomsgExample 2025-10-29T06:50:51Z command.go:212: │   name: github.com/IBM-Cloud/terraform-provider-ibm
TestRunCustomsgExample 2025-10-29T06:50:51Z command.go:212: │   version: 1.84.3
TestRunCustomsgExample 2025-10-29T06:50:51Z command.go:212: │ ---
TestRunCustomsgExample 2025-10-29T06:50:51Z command.go:212: │ 
TestRunCustomsgExample 2025-10-29T06:50:51Z command.go:212: │ 
TestRunCustomsgExample 2025-10-29T06:50:51Z command.go:212: │ 
TestRunCustomsgExample 2025-10-29T06:50:51Z command.go:212: ╵
TestRunCustomsgExample 2025-10-29T06:50:51Z retry.go:99: Returning due to fatal error: FatalError{Underlying: error while running command: exit status 1; ╷
│ Error: ---
│ id: terraform-74ff8d5a
│ summary: 'DeleteSecurityGroupTargetBindingWithContext failed: The load balancer with
│   ID ''r042-bff8eeb7-4374-43a0-961c-4cf5149e2072'' cannot be updated because its status
│   is ''UPDATE_PENDING''.'
│ severity: error
│ resource: ibm_is_security_group_target
│ operation: delete
│ component:
│   name: github.com/IBM-Cloud/terraform-provider-ibm
│   version: 1.84.3
│ ---
│ 
│ 
│ 
╵}

ocofaigh

1 comment

examples/advanced/variables.tf

terraform-ibm-modules-ops · 2025-10-29T12:08:40Z

🎉 This PR is included in version 3.68.0 🎉

The release is available on:

GitHub release
v3.68.0

Your semantic-release bot 📦🚀

Md Anam Raihan and others added 3 commits October 15, 2025 15:17

fix: extract out worker_pool logic

83ae92e

Merge branch 'main' of https://github.com/terraform-ibm-modules/terra…

657d9bc

…form-ibm-base-ocp-vpc into 16090-cds

resolve pc

5d69d89

Md Anam Raihan added 2 commits October 16, 2025 15:40

update pr_test

1cc3027

Merge branch '16090-cds' of https://github.com/terraform-ibm-modules/…

bb3ec17

…terraform-ibm-base-ocp-vpc into 16090-cds

added moved block

a4acda2

iamar7 marked this pull request as ready for review October 17, 2025 14:04

iamar7 requested review from Aashiq-J and toddgiguere as code owners October 17, 2025 14:04

iamar7 self-assigned this Oct 17, 2025

toddgiguere previously approved these changes Oct 17, 2025

View reviewed changes

iamar7 and others added 2 commits October 21, 2025 12:53

Merge branch 'main' into 16090-cds

134f5c0

update tests

49cb75a

iamar7 dismissed toddgiguere’s stale review via 49cb75a October 21, 2025 07:26

update readme

01adf44

update readme

7f9e360

toddgiguere previously approved these changes Oct 21, 2025

View reviewed changes

add worker pool example

3d4b1bc

iamar7 dismissed toddgiguere’s stale review via 3d4b1bc October 24, 2025 06:01

Md Anam Raihan added 3 commits October 24, 2025 11:51

update worker pool example

7040b3a

update default worker pool

0e860f4

add workerpool example to test

a25f222

Md Anam Raihan and others added 5 commits October 27, 2025 11:40

add worker pool example

bb31898

Merge branch '16090-cds' of https://github.com/terraform-ibm-modules/…

8f44a14

…terraform-ibm-base-ocp-vpc into 16090-cds

resolve comments

8d008dd

update README

b7ef0db

Merge branch 'main' into 16090-cds

c900e6d

maheshwarishikha previously approved these changes Oct 28, 2025

View reviewed changes

Merge branch 'main' into 16090-cds

4004c59

update cross kms example

2200dcf

iamar7 dismissed maheshwarishikha’s stale review via 2200dcf October 28, 2025 17:31

iamar7 added 3 commits October 28, 2025 17:51

revert changes

2f07b6e

remove blank line

daa451f

remove changes

f4421f3

Merge branch 'main' into 16090-cds

432a02c

update advanced example

16b9e28

ocofaigh requested changes Oct 29, 2025

View reviewed changes

examples/advanced/variables.tf Outdated Show resolved Hide resolved

update example

f2ddf66

ocofaigh approved these changes Oct 29, 2025

View reviewed changes

Merge branch 'main' into 16090-cds

3b6c5cd

ocofaigh merged commit 17585fc into main Oct 29, 2025

ocofaigh deleted the 16090-cds branch October 29, 2025 12:07

terraform-ibm-modules-ops added the released label Oct 29, 2025

Uh oh!

fix: extract out worker_pool logic #819

fix: extract out worker_pool logic #819

Uh oh!

Conversation

iamar7 commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Release required?

Release notes content

Run the pipeline

Checklist for reviewers

For mergers

Uh oh!

iamar7 commented Oct 15, 2025

Uh oh!

iamar7 commented Oct 16, 2025

Uh oh!

iamar7 commented Oct 17, 2025

Uh oh!

toddgiguere commented Oct 17, 2025

Uh oh!

iamar7 commented Oct 21, 2025

Uh oh!

iamar7 commented Oct 21, 2025

Uh oh!

iamar7 commented Oct 21, 2025

Uh oh!

iamar7 commented Oct 22, 2025

Uh oh!

iamar7 commented Oct 24, 2025

Uh oh!

iamar7 commented Oct 28, 2025

Uh oh!

ocofaigh commented Oct 28, 2025

Uh oh!

ocofaigh commented Oct 28, 2025

Uh oh!

iamar7 commented Oct 28, 2025

Uh oh!

iamar7 commented Oct 29, 2025

Uh oh!

iamar7 commented Oct 29, 2025

Uh oh!

iamar7 commented Oct 29, 2025

Uh oh!

ocofaigh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

terraform-ibm-modules-ops commented Oct 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

iamar7 commented Oct 15, 2025 •

edited

Loading