Skip to content
This repository was archived by the owner on Dec 9, 2020. It is now read-only.

Commit aadb055

Browse files
author
Giulio
committed
Updated to re-use CodeMirror as bundled with Wordpress core library
1 parent 894e064 commit aadb055

File tree

12 files changed

+18
-11325
lines changed

12 files changed

+18
-11325
lines changed

classes/EssentialScript/Admin/Scripts/CodemirrorModeJS.php

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
/**
2323
* Concrete decorator: wraps the Essential Script concrete component with
24-
* necessary code to add JavaScript mode to CodeMirror.
24+
* necessary code to add JavaScript Lint to CodeMirror.
2525
*
2626
* @author docwho
2727
*/
@@ -50,19 +50,11 @@ public function enqueueScript( $hook ) {
5050
if ( $this->slug->getSlug() !== $hook ) {
5151
return;
5252
}
53-
54-
// Codemirror mode script for javascript language.
55-
wp_register_script(
56-
'dist-codemirror-mode-js',
57-
plugins_url( ESSENTIAL_SCRIPT1_DIST_CODEMIRROR .
58-
'lib/mode/javascript/javascript.js',
59-
ESSENTIAL_SCRIPT1_PLUGIN_FILE ),
60-
array( 'dist-codemirror-script' ),
61-
self::CODEMIRROR_VER,
62-
false
63-
);
64-
wp_enqueue_script( 'dist-codemirror-mode-js' );
6553

54+
// Codemirror mode script for javascript language.
55+
if ( !wp_script_is( 'jshint', 'enqueued' ) ) {
56+
wp_enqueue_script( 'jshint' );
57+
}
6658
}
6759

6860
/**

classes/EssentialScript/Admin/Scripts/CodemirrorModeXml.php

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
/**
2323
* Concrete decorator: wraps the Essential Script concrete component with
24-
* necessary code to add XML mode to CodeMirror.
24+
* necessary code to add HTML/XML lint to CodeMirror.
2525
*
2626
* @author docwho
2727
*/
@@ -52,16 +52,9 @@ public function enqueueScript( $hook ) {
5252
}
5353

5454
// Codemirror mode script for XML/HTML language.
55-
wp_register_script(
56-
'dist-codemirror-mode-xml',
57-
plugins_url( ESSENTIAL_SCRIPT1_DIST_CODEMIRROR .
58-
'lib/mode/xml/xml.js',
59-
ESSENTIAL_SCRIPT1_PLUGIN_FILE ),
60-
array( 'dist-codemirror-script' ),
61-
self::CODEMIRROR_VER,
62-
false
63-
);
64-
wp_enqueue_script( 'dist-codemirror-mode-xml' );
55+
if ( !wp_script_is( 'htmlhint', 'enqueued' ) ) {
56+
wp_enqueue_script( 'htmlhint' );
57+
}
6558
}
6659

6760
/**

classes/EssentialScript/Admin/Scripts/CodemirrorScript.php

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -51,18 +51,11 @@ public function enqueueScript( $hook ) {
5151
}
5252

5353
// Codemirror main javascript file
54-
wp_register_script(
55-
'dist-codemirror-script',
56-
plugins_url( ESSENTIAL_SCRIPT1_DIST_CODEMIRROR .
57-
'lib/codemirror.js',
58-
ESSENTIAL_SCRIPT1_PLUGIN_FILE ),
59-
array (),
60-
self::CODEMIRROR_VER,
61-
false
62-
);
63-
wp_enqueue_script( 'dist-codemirror-script' );
54+
if ( !wp_script_is( 'wp-codemirror', 'enqueued' ) ) {
55+
wp_enqueue_script( 'wp-codemirror' );
56+
}
6457
}
65-
58+
6659
/**
6760
* Getter
6861
*

classes/EssentialScript/Admin/Scripts/CodemirrorStyle.php

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
/**
2323
* Concrete decorator: wraps the Essential Script concrete component with
24-
* necessary code to add CSS file supplied by CodeMirror.
24+
* necessary code to add CSS file for Codemirror supplied by WordPress.
2525
*
2626
* @author docwho
2727
*/
@@ -52,18 +52,8 @@ public function enqueueScript( $hook ) {
5252
return;
5353
}
5454

55-
// CodeMirror style
56-
wp_register_style(
57-
'dist-codemirror-style',
58-
plugins_url( ESSENTIAL_SCRIPT1_DIST_CODEMIRROR .
59-
'lib/codemirror.css',
60-
ESSENTIAL_SCRIPT1_PLUGIN_FILE ),
61-
array(),
62-
self::CODEMIRROR_VER,
63-
false
64-
);
65-
wp_enqueue_style( 'dist-codemirror-style' );
66-
55+
// CodeMirror main style
56+
wp_enqueue_style( 'wp-codemirror' );
6757
}
6858

6959
/**

classes/EssentialScript/Admin/Scripts/CodemirrorStyleOverride.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ public function enqueueScript( $hook ) {
5656
'codemirror-style-override',
5757
plugins_url( 'css/codemirror-override.css', ESSENTIAL_SCRIPT1_PLUGIN_FILE ),
5858
array(),
59-
self::CODEMIRROR_VER,
59+
self::ESSENTIALSCRIPT_VER,
6060
false
6161
);
6262
wp_enqueue_style( 'codemirror-style-override' );

classes/EssentialScript/Admin/Scripts/Component.php

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,6 @@
2525
* @author docwho
2626
*/
2727
abstract class Component {
28-
/**
29-
* CodeMirror Version for upgrade purposes.
30-
*
31-
* @since 0.2
32-
*/
33-
const CODEMIRROR_VER = '5.32.0';
3428
/**
3529
* Essential Script Version for upgrade purposes.
3630
*

classes/EssentialScript/Core/Codemirror.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ static public function fromTextarea( $highlighter ) {
5959
<script>
6060
(function($,settings) {
6161
var textarea_node=document.getElementById("textarea-script");
62-
var editor = CodeMirror.fromTextArea(textarea_node,settings);
62+
var editor = wp.CodeMirror.fromTextArea(textarea_node,settings);
6363
})(window.jQuery, %s);
6464
</script>
6565
JS

essential-script.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@
4545
define ( 'ESSENTIAL_SCRIPT1_PLUGIN_DIR', plugin_dir_path( __FILE__ ) );
4646
define ( 'ESSENTIAL_SCRIPT1_PLUGIN_FILE', __FILE__ );
4747
define ( 'ESSENTIAL_SCRIPT1_PLUGIN_PACKAGE', 'EssentialScript' );
48-
define ( 'ESSENTIAL_SCRIPT1_DIST_CODEMIRROR', 'lib/codemirror/' );
4948

5049
// Include or require any necessary files here.
5150
require_once ( ESSENTIAL_SCRIPT1_PLUGIN_DIR . 'classes/EssentialScript/Tools/Autoloader.php' );

0 commit comments

Comments
 (0)