Skip to content

Commit 2f21d38

Browse files
authored
Merge pull request #174 from smarunich/1.5.x-backport
backport fixes
2 parents 2e99da5 + ee46d65 commit 2f21d38

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

infra/gcp/main.tf

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@ resource "google_project" "tsb" {
1616
labels = {
1717
name = "${var.name_prefix}_project"
1818
environment = "${var.name_prefix}_tsb"
19-
owner = "${var.tsb_image_sync_username}"
19+
owner = replace(var.tsb_image_sync_username, "/\\W+/", "-")
2020
}
2121
}
2222

2323
module "gcp_base" {
2424
source = "../../modules/gcp/base"
2525
count = var.gcp_k8s_region == null ? 0 : 1
26-
owner = "${var.tsb_image_sync_username}"
26+
owner = replace(var.tsb_image_sync_username, "/\\W+/", "-")
2727
name_prefix = "${var.name_prefix}-${var.cluster_id}"
2828
project_id = var.gcp_project_id == null ? google_project.tsb[0].project_id : var.gcp_project_id
2929
region = var.gcp_k8s_region
@@ -35,7 +35,7 @@ module "gcp_base" {
3535
module "gcp_jumpbox" {
3636
source = "../../modules/gcp/jumpbox"
3737
count = var.gcp_k8s_region == null ? 0 : 1
38-
owner = "${var.tsb_image_sync_username}"
38+
owner = replace(var.tsb_image_sync_username, "/\\W+/", "-")
3939
name_prefix = "${var.name_prefix}-${var.cluster_id}"
4040
region = var.gcp_k8s_region
4141
project_id = var.gcp_project_id == null ? google_project.tsb[0].project_id : var.gcp_project_id
@@ -53,7 +53,7 @@ module "gcp_jumpbox" {
5353
module "gcp_k8s" {
5454
source = "../../modules/gcp/k8s"
5555
count = var.gcp_k8s_region == null ? 0 : 1
56-
owner = "${var.tsb_image_sync_username}"
56+
owner = replace(var.tsb_image_sync_username, "/\\W+/", "-")
5757
name_prefix = "${var.name_prefix}-${var.cluster_id}"
5858
cluster_name = var.cluster_name == null ? "gke-${var.gcp_k8s_region}-${var.name_prefix}" : var.cluster_name
5959
project_id = var.gcp_project_id == null ? google_project.tsb[0].project_id : var.gcp_project_id

modules/gcp/k8s/main.tf

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,9 @@ module "gke_auth" {
6161
cluster_name = google_container_cluster.tsb.name
6262
location = var.region
6363
use_private_endpoint = false
64+
depends_on = [
65+
google_project_service.container
66+
]
6467
}
6568

6669
resource "local_file" "kubeconfig" {

0 commit comments

Comments
 (0)