tfsaggregator
diff --git a/‎.github/dependabot.yml‎
Lines changed: 0 additions & 17 deletions b/‎.github/dependabot.yml‎
Lines changed: 0 additions & 17 deletions
diff --git a/‎.github/workflows/build-and-deploy.yml‎
Lines changed: 3 additions & 3 deletions b/‎.github/workflows/build-and-deploy.yml‎
Lines changed: 3 additions & 3 deletions
diff --git a/‎Next-Release-ChangeLog.md‎
Lines changed: 13 additions & 19 deletions b/‎Next-Release-ChangeLog.md‎
Lines changed: 13 additions & 19 deletions
diff --git a/‎src/aggregator-cli.sln‎
Lines changed: 6 additions & 0 deletions b/‎src/aggregator-cli.sln‎
Lines changed: 6 additions & 0 deletions
diff --git a/‎src/aggregator-cli/ContextExtensions.cs‎
Lines changed: 13 additions & 0 deletions b/‎src/aggregator-cli/ContextExtensions.cs‎
Lines changed: 13 additions & 0 deletions
diff --git a/‎src/aggregator-cli/GlobalSuppressions.cs‎
Lines changed: 1 addition & 0 deletions b/‎src/aggregator-cli/GlobalSuppressions.cs‎
Lines changed: 1 addition & 0 deletions
diff --git a/‎src/aggregator-cli/Instances/AggregatorInstances.cs‎
Lines changed: 2 additions & 0 deletions b/‎src/aggregator-cli/Instances/AggregatorInstances.cs‎
Lines changed: 2 additions & 0 deletions
diff --git a/‎src/aggregator-cli/Instances/ConfigureInstanceCommand.cs‎
Lines changed: 1 addition & 0 deletions b/‎src/aggregator-cli/Instances/ConfigureInstanceCommand.cs‎
Lines changed: 1 addition & 0 deletions
diff --git a/‎src/aggregator-cli/Instances/FunctionRuntimePackage.cs‎
Lines changed: 2 additions & 0 deletions b/‎src/aggregator-cli/Instances/FunctionRuntimePackage.cs‎
Lines changed: 2 additions & 0 deletions
diff --git a/‎src/aggregator-cli/Instances/InstallInstanceCommand.cs‎
Lines changed: 1 addition & 0 deletions b/‎src/aggregator-cli/Instances/InstallInstanceCommand.cs‎
Lines changed: 1 addition & 0 deletions
@@ -39,12 +39,12 @@ jobs:
       run: echo ::set-output name=tag_name::${GITHUB_REF/refs\/tags\//}
       shell: bash
     - name: Install GitVersion
-      uses: gittools/actions/gitversion/[email protected].4
+      uses: gittools/actions/gitversion/[email protected].7
       with:
-          versionSpec: '5.3.x'
+          versionSpec: '5.5.x'
     - name: Use GitVersion
       id: gitversion # step id used as reference for output values
-      uses: gittools/actions/gitversion/[email protected].4
+      uses: gittools/actions/gitversion/[email protected].7
     - name: 'Set version in aggregator-manifest.ini'
       run: 'sed -E -i "s/version=.*/version=${{ steps.gitversion.outputs.fullSemVer }}/" ${GITHUB_WORKSPACE}/src/aggregator-function/aggregator-manifest.ini'
       shell: bash
 
@@ -1,41 +1,35 @@
-This is the inital **1.0** release.
+This release fixes a number of issues and introduce an additional CLI command.
+
 
 CLI Commands and Options
 ========================
-* Resolve code analysis warnings.
-* Fix incorrect HTTP Header in web hook Subscriptions made by `map.local.rule`.
-* Fix incorrect URL in web hook Subscriptions made by `map.local.rule`.
+- Removed annoying messages about new version check.
+- Deprecation warning on missing `--resourceGroup` option.
+- Changed `IDataProtectionProvider.CreateProtector` purpose string to prevent clashes.
+- New `update.mappings` command.
 
 
 Docker and Azure Function Hosting
 ========================
-* Resolve code analysis warnings.
-* Fix CS1705 error.
-* Support for `Aggregator_AzureDevOpsCertificate` when Azure DevOps is using a certificate issued by non-trusted Certification Authority (e.g.self-signed).
-* Better handling of API keys.
+- Retry after Http 429 using Polly, address #71.
+- Harden Azure resources (see #225).
 
 
 Rule Language
 ========================
-* New optional `events` directive.
+No changes.
 
 
 Rule Interpreter Engine
 ========================
-* Resolve code analysis warnings.
-* Improved some messages.
+- Address #185 by removing field when set to null value.
+- Impersonation does not work when a rule updates the same work item bug (#206).
 
 
 Build, Test, Documentation
 ========================
-* Updated to the latest version of NuGet packages except for Function SDK and Logging.
-* Stick to `Microsoft.NET.Sdk.Functions` 3.0.3 until they resolve [#465](https://github.com/Azure/azure-functions-vs-build-sdk/issues/465). This locks `Microsoft.Extensions.Logging` to 3.1.6 too.
-* Resolve code analysis warnings.
-* Fix default branch reference in CI workflow.
-* Push docker images to GitHub Container Registry (beta) in addition to Docker Hub.
-* Local version number is now `0.0.1-localdev`.
-* Fix build badge, added SonarQube badge.
-* Trimmed `.dockerignore`.
+- Terraform and PowerShell scripts to setup a dev VM.
+- Use latest GitVersion.
 
 
 File Hashes
 
@@ -45,6 +45,12 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "docker", "docker", "{F0E724
 		win-x64.Dockerfile = win-x64.Dockerfile
 	EndProjectSection
 EndProject
+Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "doc", "doc", "{72427DCE-8A20-45E5-A5E4-781E7E4C1A34}"
+	ProjectSection(SolutionItems) = preProject
+		..\Next-Release-ChangeLog.md = ..\Next-Release-ChangeLog.md
+		..\README.md = ..\README.md
+	EndProjectSection
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
 
@@ -0,0 +1,13 @@
+namespace aggregator.cli
+{
+    static class ContextExtensions
+    {
+        public static void ResourceGroupDeprecationCheck(this CommandContext ctx, string rg)
+        {
+            if (string.IsNullOrWhiteSpace(rg))
+            {
+                ctx.Logger.WriteWarning($"Deprecation notice: the resourceGroup option will be mandatory in a future version of Aggregator.");
+            }
+        }
+    }
+}
@@ -8,3 +8,4 @@
 [assembly: SuppressMessage("Critical Code Smell", "S3966:Objects should not be disposed more than once", Justification = "We dispose only BCL objects and we trust how they implemented Dispose()")]
 [assembly: SuppressMessage("Info Code Smell", "S1135:Track uses of \"TODO\" tags", Justification = "Leave markers")]
 [assembly: SuppressMessage("Major Code Smell", "S125:Sections of code should not be commented out", Justification = "THey are TODOs")]
+[assembly: SuppressMessage("CodeQuality", "IDE0079:Remove unnecessary suppression", Justification = "Do not warn")]
@@ -338,7 +338,9 @@ private static async Task<Dictionary<string, string>> UpdateDefaultFilesAsync(Fu
                 var entry = archive.Entries
                                    .Single(e => string.Equals("aggregator-function.dll", e.Name, StringComparison.OrdinalIgnoreCase));
 
+#pragma warning disable S5042 // Make sure that decompressing this archive file is safe
                 using (var assemblyStream = entry.Open())
+#pragma warning restore S5042 // Make sure that decompressing this archive file is safe
                 {
                     await uploadFiles.AddFunctionDefaultFiles(assemblyStream);
                 }
 
@@ -35,6 +35,7 @@ internal override async Task<int> RunAsync(CancellationToken cancellationToken)
                 .WithAzureLogon()
                 .WithDevOpsLogon() // need the token, so we can save it in the app settings
                 .BuildAsync(cancellationToken);
+            context.ResourceGroupDeprecationCheck(this.ResourceGroup);
             var instances = new AggregatorInstances(context.Azure, context.Logger, context.Naming);
             var instance = context.Naming.Instance(Name, ResourceGroup);
             if (Authentication)
 
@@ -329,7 +329,9 @@ private async Task<SemVersion> GetLocalPackageVersionAsync(string runtimePackage
             using (var zip = ZipFile.OpenRead(runtimePackageFile))
             {
                 var manifestEntry = zip.GetEntry("aggregator-manifest.ini");
+#pragma warning disable S5042 // Make sure that decompressing this archive file is safe
                 using (var byteStream = manifestEntry.Open())
+#pragma warning restore S5042 // Make sure that decompressing this archive file is safe
                 using (var reader = new StreamReader(byteStream))
                 {
                     var content = await reader.ReadToEndAsync();
 
@@ -67,6 +67,7 @@ internal override async Task<int> RunAsync(CancellationToken cancellationToken)
                 .WithAzureLogon()
                 .WithDevOpsLogon() // need the token, so we can save it in the app settings
                 .BuildAsync(cancellationToken);
+            context.ResourceGroupDeprecationCheck(this.ResourceGroup);
             var instances = new AggregatorInstances(context.Azure, context.Logger, context.Naming);
             var instance = context.Naming.GetInstanceCreateNames(Name, ResourceGroup);
             bool ok = await instances.AddAsync(instance, Location, RequiredVersion, SourceUrl, tuning, cancellationToken);
Original file line number	Diff line number	Diff line change
`@@ -338,7 +338,9 @@ private static async Task<Dictionary<string, string>> UpdateDefaultFilesAsync(Fu`
`338`	`338`	`var entry = archive.Entries`
`339`	`339`	`.Single(e => string.Equals("aggregator-function.dll", e.Name, StringComparison.OrdinalIgnoreCase));`
`340`	`340`
	`341`	`+#pragma warning disable S5042 // Make sure that decompressing this archive file is safe`
`341`	`342`	`using (var assemblyStream = entry.Open())`
	`343`	`+#pragma warning restore S5042 // Make sure that decompressing this archive file is safe`
`342`	`344`	`{`
`343`	`345`	`await uploadFiles.AddFunctionDefaultFiles(assemblyStream);`
`344`	`346`	`}`
Original file line number	Diff line number	Diff line change
`@@ -329,7 +329,9 @@ private async Task<SemVersion> GetLocalPackageVersionAsync(string runtimePackage`
`329`	`329`	`using (var zip = ZipFile.OpenRead(runtimePackageFile))`
`330`	`330`	`{`
`331`	`331`	`var manifestEntry = zip.GetEntry("aggregator-manifest.ini");`
	`332`	`+#pragma warning disable S5042 // Make sure that decompressing this archive file is safe`
`332`	`333`	`using (var byteStream = manifestEntry.Open())`
	`334`	`+#pragma warning restore S5042 // Make sure that decompressing this archive file is safe`
`333`	`335`	`using (var reader = new StreamReader(byteStream))`
`334`	`336`	`{`
`335`	`337`	`var content = await reader.ReadToEndAsync();`