fix: #225: coding standard & stan

Author: TLG-Gildas

src/Attribute/WithAccessTokenTTL.php

@@ -1,12 +1,14 @@
-<?php declare(strict_types=1);
+<?php
+
+declare(strict_types=1);
 
 namespace League\Bundle\OAuth2ServerBundle\Attribute;
 
 #[\Attribute(\Attribute::TARGET_CLASS)]
 class WithAccessTokenTTL
 {
     // we don't allow to pass directly \DateInterval, to not break symfony container dumping which require serializable object
-    public function __construct(public readonly string|null $accessTokenTTL)
+    public function __construct(public readonly ?string $accessTokenTTL)
     {
     }
 }

src/DependencyInjection/CompilerPass/GrantTypePass.php

@@ -49,9 +49,8 @@ public function process(ContainerBuilder $container): void
 
                     // read of accessTokenTTL from WithAccessTokenTTL attribute
                     $withAccessTokenTTLAttributes = $refGrantClass->getAttributes(WithAccessTokenTTL::class);
-                    if (count($withAccessTokenTTLAttributes) > 0) {
+                    if (\count($withAccessTokenTTLAttributes) > 0) {
                         // we only use first attribute, because WithAccessTokenTTL is not repeatable
-                        /** @var \ReflectionAttribute<WithAccessTokenTTL> $withAccessTokenTTLAttribute */
                         $withAccessTokenTTLAttributeArguments = array_shift($withAccessTokenTTLAttributes)->getArguments();
                         $attributes['accessTokenTTL'] = array_shift($withAccessTokenTTLAttributeArguments);
                     }
@@ -67,7 +66,7 @@ public function process(ContainerBuilder $container): void
 
             $definition->addMethodCall('enableGrantType', [
                 new Reference($id),
-                (is_string($accessTokenTTLValue))
+                (\is_string($accessTokenTTLValue))
                     ? new Definition(\DateInterval::class, [$accessTokenTTLValue])
                     : $accessTokenTTLValue,
             ]);

tests/Integration/AuthorizationServerCustomGrantTest.php

@@ -45,7 +45,7 @@ public function testAuthorizationServerHasOurCustomGrantEnabled(): void
         $this->assertGrantConfig('fake_legacy_grant', new \DateInterval('PT5H'), $enabledGrantTypes, $grantTypeAccessTokenTTL, FakeLegacyGrant::class);
     }
 
-    private function assertGrantConfig(string $grantId, \DateInterval|null $accessTokenTTL, array $enabledGrantTypes, array $grantTypeAccessTokenTTL, string|null $grantClass = null): void
+    private function assertGrantConfig(string $grantId, ?\DateInterval $accessTokenTTL, array $enabledGrantTypes, array $grantTypeAccessTokenTTL, ?string $grantClass = null): void
     {
         $grantClass ??= $grantId;
 

tests/TestKernel.php

@@ -5,7 +5,6 @@
 namespace League\Bundle\OAuth2ServerBundle\Tests;
 
 use Doctrine\DBAL\Platforms\SqlitePlatform;
-use Doctrine\ORM\Mapping\Annotation;
 use League\Bundle\OAuth2ServerBundle\Manager\AccessTokenManagerInterface;
 use League\Bundle\OAuth2ServerBundle\Manager\AuthorizationCodeManagerInterface;
 use League\Bundle\OAuth2ServerBundle\Manager\ClientManagerInterface;
@@ -174,7 +173,7 @@ public function registerContainerConfiguration(LoaderInterface $loader): void
                 'authorization_server' => [
                     'private_key' => '%env(PRIVATE_KEY_PATH)%',
                     'encryption_key' => '%env(ENCRYPTION_KEY)%',
-                    'access_token_ttl' => 'PT2H' // to have a different value as league/oauth2-server lib
+                    'access_token_ttl' => 'PT2H', // to have a different value as league/oauth2-server lib
                 ],
                 'resource_server' => $this->resourceServiceConfig ?? ['public_key' => '%env(PUBLIC_KEY_PATH)%'],
                 'scopes' => [