code-climate: mypy: address remaining arg-type: review findings

Author: thseiler

strictdoc/core/actions/export_action.py

@@ -74,6 +74,12 @@ def export(self) -> None:
             # The bundle document is generated only when the option is provided.
             traceability_index_copy: Optional[TraceabilityIndex] = None
             bundle_document: Optional[SDocDocument] = None
+            if self.project_config.generate_bundle_document:
+                traceability_index_copy, bundle_document = (
+                    self.traceability_index.clone_to_bundle_document(
+                        self.project_config
+                    )
+                )
 
             if (
                 "html" in self.project_config.export_formats
@@ -87,11 +93,6 @@ def export(self) -> None:
                     parallelizer=self.parallelizer,
                 )
                 if self.project_config.generate_bundle_document:
-                    traceability_index_copy, bundle_document = (
-                        self.traceability_index.clone_to_bundle_document(
-                            self.project_config
-                        )
-                    )
                     assert bundle_document is not None, (
                         "bundle_document must not be None."
                     )

strictdoc/core/traceability_index_builder.py

@@ -85,12 +85,12 @@ def create(
         latest_strictdoc_own_file = (
             max(strict_own_files, key=os.path.getctime)
             if len(strict_own_files) > 0
-            else ""
+            else None
         )
 
         strictdoc_last_update: datetime.datetime = (
             get_file_modification_time(latest_strictdoc_own_file)
-            if (latest_strictdoc_own_file != "")
+            if (latest_strictdoc_own_file is not None)
             else datetime.datetime.fromtimestamp(0)
         )
         if (

strictdoc/export/spdx/spdx_generator.py

@@ -83,7 +83,9 @@ def get_spdx_ref(node: Union[SDocDocument, SDocNode, str]) -> str:
     elif node.reserved_title is not None:
         identifier = re.sub(r"[ #-/\\]", "_", node.reserved_title)
     else:
-        raise RuntimeError("Cannot create unique identifier for this node.")
+        raise RuntimeError(
+            f"Cannot create unique identifier for this node: {node}"
+        )
 
     if isinstance(node, SDocDocument):
         return "SDocDocument-" + identifier

strictdoc/git/project_diff_analyzer.py

@@ -824,15 +824,15 @@ def create_comment_field_changes(
 
         changes = []
 
-        changed_fields: Set[SDocNodeField] = set(
-            requirement.ordered_fields_lookup.get("COMMENT", [])
+        changed_fields: Dict[SDocNodeField, None] = dict.fromkeys(
+            requirement.ordered_fields_lookup.get("COMMENT", []), None
         )
-        changed_other_fields: Set[SDocNodeField] = set(
-            other_requirement.ordered_fields_lookup.get("COMMENT", [])
+        changed_other_fields: Dict[SDocNodeField, None] = dict.fromkeys(
+            other_requirement.ordered_fields_lookup.get("COMMENT", []), None
         )
 
         if len(changed_fields) == 0 or len(changed_other_fields) == 0:
-            for changed_field_ in changed_fields:
+            for changed_field_ in changed_fields.keys():
                 changes.append(
                     RequirementFieldChange(
                         field_name="COMMENT",
@@ -842,7 +842,7 @@ def create_comment_field_changes(
                         right_diff=None,
                     )
                 )
-            for changed_other_field_ in changed_other_fields:
+            for changed_other_field_ in changed_other_fields.keys():
                 changes.append(
                     RequirementFieldChange(
                         field_name="COMMENT",
@@ -864,8 +864,8 @@ def create_comment_field_changes(
 
                 similarity = similar(comment_value, comment_other_value)
                 if similarity == 1:
-                    changed_fields.remove(changed_field_)
-                    changed_other_fields.remove(changed_other_field_)
+                    del changed_fields[changed_field_]
+                    del changed_other_fields[changed_other_field_]
                     break
 
                 similarities.append(
@@ -905,8 +905,8 @@ def create_comment_field_changes(
                     right_diff=right_diff,
                 )
             )
-            changed_fields.remove(changed_field_)
-            changed_other_fields.remove(changed_other_field_)
+            del changed_fields[changed_field_]
+            del changed_other_fields[changed_other_field_]
 
         # Iterate over remaining fields.
         for changed_field_ in changed_fields: