apply to ggproto() and deduplicate members

Author: teunbrand

R/ggproto.R

@@ -68,9 +68,7 @@ ggproto <- function(`_class` = NULL, `_inherit` = NULL, ...) {
   e <- new.env(parent = emptyenv())
 
   members <- list2(...)
-  if (length(members) != sum(nzchar(names(members)))) {
-    cli::cli_abort("All members of a {.cls ggproto} object must be named.")
-  }
+  check_named(members, I("Members of a {.cls ggproto} object"))
 
   # R <3.1.2 will error when list2env() is given an empty list, so we need to
   # check length. https://github.com/tidyverse/ggplot2/issues/1444

R/stat-bindot.R

@@ -6,7 +6,9 @@ StatBindot <- ggproto("StatBindot", Stat,
   required_aes = "x",
   non_missing_aes = "weight",
   default_aes = aes(y = after_stat(count)),
-  dropped_aes = c("bin", "bincenter"), # these are temporary variables that are created and then removed by the stat
+
+  # these are temporary variables that are created and then removed by the stat
+  dropped_aes = c("weight", "bin", "bincenter"),
 
   setup_params = function(data, params) {
     if (is.null(params$binwidth)) {
@@ -122,9 +124,7 @@ StatBindot <- ggproto("StatBindot", Stat,
       data$x <- midline
     }
     return(data)
-  },
-
-  dropped_aes = c("weight", "bin", "bincenter")
+  }
 )
 
 

tests/testthat/_snaps/ggproto.md

@@ -1,15 +1,19 @@
 # construction checks input
 
-    All members of a <ggproto> object must be named.
+    Members of a <ggproto> object must have names.
 
 ---
 
-    All members of a <ggproto> object must be named.
+    Members of a <ggproto> object must have names.
 
 ---
 
     `_inherit` must be a <ggproto> object, not a <data.frame> object.
 
+---
+
+    Members of a <ggproto> object cannot have duplicate names ("foo").
+
 # ggproto objects print well
 
     Code

tests/testthat/test-ggproto.R

@@ -9,6 +9,8 @@ test_that("construction checks input", {
   expect_snapshot_error(ggproto("Test", NULL, function(self, a) a))
   expect_snapshot_error(ggproto("Test", NULL, a <- function(self, a) a))
   expect_snapshot_error(ggproto("Test", mtcars, a = function(self, a) a))
+  # Duplicate names
+  expect_snapshot_error(ggproto("Test", NULL, foo = 20, foo = "A"))
 })
 
 test_that("all ggproto methods start with `{` (#6459)", {