Fix label formatting bug in warning (#6483)

* handle warnings about function-labels

* include in test

* approve snapshot of updated test

Author: teunbrand

R/labels.R

@@ -80,10 +80,17 @@ setup_plot_labels <- function(plot, layers, data) {
   extra_labels <- setdiff(names(plot_labels), known_labels)
 
   if (length(extra_labels) > 0) {
-    extra_labels <- paste0(
-      "{.code ", extra_labels, " = \"", plot_labels[extra_labels], "\"}"
+
+    warn_labels <- plot_labels[extra_labels]
+    warn_labels <- ifelse(
+      vapply(warn_labels, is.function, logical(1)),
+      "{.cls function}",
+      paste0("{.val ", warn_labels, "}")
     )
+
+    extra_labels <- paste0("{.field ", extra_labels, "} : ", warn_labels)
     names(extra_labels) <- rep("*", length(extra_labels))
+
     cli::cli_warn(c(
       "Ignoring unknown labels:",
       extra_labels

tests/testthat/_snaps/labels.md

@@ -15,7 +15,9 @@
 # warnings are thrown for unknown labels
 
     Ignoring unknown labels:
-    * `foo = "bar"`
+    * foo : "i don't exist"
+    * bar : <function>
+    * qux : "expression(me * neither)"
 
 # plot.tag.position rejects invalid input
 

tests/testthat/test-labels.R

@@ -110,7 +110,13 @@ test_that("get_alt_text checks dots", {
 })
 
 test_that("warnings are thrown for unknown labels", {
-  p <- ggplot(mtcars, aes(mpg, disp)) + geom_point() + labs(foo = 'bar')
+  p <- ggplot(mtcars, aes(mpg, disp)) +
+    geom_point() +
+    labs(
+      foo = "i don't exist",
+      bar = function(x) "i don't exist either",
+      qux = expression(me * neither)
+    )
   expect_snapshot_warning(ggplot_build(p))
 })