Skip to content

Conversation

yutannihilation
Copy link
Member

Positron warns me a lot about the YAML syntax of fig.alt. Interestingly, if I re-render the README, there's no difference on alt of the corresponding <img> tag. So, it seems R Markdown is more permissive than Positron, and this is not a real problem. But, I think it's good to use valid YAML syntax anyway.

image

@yutannihilation yutannihilation marked this pull request as draft September 6, 2024 06:10
@yutannihilation yutannihilation marked this pull request as ready for review September 6, 2024 06:37
Copy link
Collaborator

@teunbrand teunbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Probably would need these changes as well if we decide to implement #5760.

@yutannihilation
Copy link
Member Author

Ah, probably yes. I actually used Quarto for validating the syntax because Quarto doesn't allow #| fig.alt =. Thanks for reviewing!

@yutannihilation yutannihilation merged commit 0d3757d into tidyverse:main Sep 6, 2024
13 checks passed
@yutannihilation yutannihilation deleted the doc/fix-fig.alt branch September 6, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants