Simpler route defintion

[chrisoldwood]

I'm using Hornbill via C# and I've created the following extension method to make routes even simpler to define:

internal static class FakeServiceExtensions
{
    public static void Get(this FakeService service, string path, Func<Request, Response> response)
    {
        service.AddResponse(path, Method.GET, Response.WithDelegate(response));
    }

    public static void Post(this FakeService service, string path, Func<Request, Response> response)
    {
        service.AddResponse(path, Method.POST, Response.WithDelegate(response));
    }
}

This removes some of the ceremony and allows me to write them in a more Nancy like manner:

fakeService.Get("/api/thing/.*", request =>
{
    . . .
    return Response.WithBody(200, ...);
});

What do you think? Do you like the idea of having methods named Get/Put/Post/etc. on the type or would it better to keep them as extensions? Presumably it's possible to define C# style extension methods in F# (or does that not even make sense)?

[JonCanning]

Sure, you happy to do it? Could be cleaner as a type extension in a separate file

[CraftyFella]

Possible builder style which returns fakeservice so you can chain them together... ?

[chrisoldwood]

Possible builder style which returns fakeservice so you can chain them together... ?

I feel in the example above a builder would double the amount of code. For a simple request you only need the verb (do you, really?) and the url and the rest is the handler. Perhaps if you wanted to include matches against headers and query string then a builder might be more useful, e.g.

fake.ForMethod("GET")
     .AndBaseUrl("/api/thing")
     .WithQueryParam("parameter")
     .WithHeaderMatching("Accept", "json")
     .RespondWith(200, new { message = "Hello, World!" })
     .Start();

Sure, you happy to do it? Could be cleaner as a type extension in a separate file

I'll look into in the background. My immediate needs have been met but I wanted to contribute something back if I could. My F# is somewhat rusty so bear with :o).

[CraftyFella]

I like the initial suggestions.. why haven't we just added these extension methods?