goenv: parse patch version, add func Compare to compare two Go version strings #4536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aykevl
approved these changes
Oct 21, 2024
Member
aykevl
left a comment
aykevl
left a comment
There was a problem hiding this comment.
LGTM.
Was this intended to be kept as separate commits or can this be squashed when merging?
Member
Contributor
Author
Squashed! Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements 3 changes:
goenv.Parsenow parses patch version out of a Go version string.goenv.Compareto compare two Go version strings. This is used in compiler: conform to latest iteration of wasm types proposal #4501 to enablestructs.HostLayoutenforcement.ParseandCompare.Extracted from #4501.