feat(bus): fetch fcps afternoon bus delays

Closes #1413

Author: mktaher

config/scripts/create_users.py

@@ -5,11 +5,10 @@
 import random
 from datetime import datetime
 
+import django
 import names
 from dateutil.relativedelta import relativedelta
 
-import django
-
 os.environ.setdefault("DJANGO_SETTINGS_MODULE", "intranet.settings")
 django.setup()
 

fabfile.py

@@ -15,7 +15,7 @@ def _choose_from_list(options, question):
     """Choose an item from a list."""
     message = ""
     for index, value in enumerate(options):
-        message += "[{}] {}\n".format(index, value)
+        message += f"[{index}] {value}\n"
     message += "\n" + question
 
     def valid(n):
@@ -44,7 +44,7 @@ def runserver(
     yes_or_no = ("debug_toolbar", "werkzeug", "dummy_cache", "short_cache", "template_warnings", "insecure")
     for s in yes_or_no:
         if locals()[s].lower() not in ("yes", "no"):
-            abort("Specify 'yes' or 'no' for {} option.".format(s))
+            abort(f"Specify 'yes' or 'no' for {s} option.")
 
     _log_levels = ("DEBUG", "INFO", "WARNING", "ERROR", "CRITICAL")
     if log_level not in _log_levels:
@@ -120,9 +120,9 @@ def clear_sessions(venv=None):
         return 0
 
     if count > 0:
-        local("{0}| xargs redis-cli -n " "{1} DEL".format(keys_command, REDIS_SESSION_DB))
+        local(f"{keys_command}| xargs redis-cli -n " f"{REDIS_SESSION_DB} DEL")
 
-        puts("Destroyed {} session{}.".format(count, plural))
+        puts(f"Destroyed {count} session{plural}.")
 
 
 def clear_cache(input=None):
@@ -133,9 +133,9 @@ def clear_cache(input=None):
         n = _choose_from_list(["Production cache", "Sandbox cache"], "Which cache would you like to clear?")
 
     if n == 0:
-        local("redis-cli -n {} FLUSHDB".format(REDIS_PRODUCTION_CACHE_DB))
+        local(f"redis-cli -n {REDIS_PRODUCTION_CACHE_DB} FLUSHDB")
     else:
-        local("redis-cli -n {} FLUSHDB".format(REDIS_SANDBOX_CACHE_DB))
+        local(f"redis-cli -n {REDIS_SANDBOX_CACHE_DB} FLUSHDB")
 
 
 def contributors():
@@ -156,7 +156,7 @@ def deploy():
     with lcd(PRODUCTION_DOCUMENT_ROOT):
         with shell_env(PRODUCTION="TRUE"):
             local("git pull")
-            with open("requirements.txt", "r") as req_file:
+            with open("requirements.txt") as req_file:
                 requirements = req_file.read().strip().split()
                 try:
                     pkg_resources.require(requirements)
@@ -179,8 +179,8 @@ def forcemigrate(app=None):
     """Force migrations to apply for a given app."""
     if app is None:
         abort("No app name given.")
-    local("./manage.py migrate {} --fake".format(app))
-    local("./manage.py migrate {}".format(app))
+    local(f"./manage.py migrate {app} --fake")
+    local(f"./manage.py migrate {app}")
 
 
 def inspect_decorators():

intranet/apps/announcements/api.py

@@ -11,8 +11,8 @@
 class IsAnnouncementAdminOrReadOnly(permissions.BasePermission):
     def has_permission(self, request, view):
         return (
-            request.user and request.user.is_authenticated and not request.user.is_restricted and request.user.oauth_and_api_access or request.auth
-        ) and (request.method in permissions.SAFE_METHODS or request.user and request.user.is_announcements_admin)
+            (request.user and request.user.is_authenticated and not request.user.is_restricted and request.user.oauth_and_api_access) or request.auth
+        ) and (request.method in permissions.SAFE_METHODS or (request.user and request.user.is_announcements_admin))
 
 
 class ListCreateAnnouncement(generics.ListCreateAPIView):

intranet/apps/announcements/models.py

@@ -175,14 +175,12 @@ def is_visible(self, user):
         return self in Announcement.objects.visible_to_user(user)
 
     def can_modify(self, user):
-        return (
-            user.is_announcements_admin
-            or self.is_club_announcement
+        return user.is_announcements_admin or (
+            self.is_club_announcement
             and (
                 user in self.activity.officers.all()
                 or user in self.activity.club_sponsors.all()
-                or EighthSponsor.objects.filter(user=user).exists()
-                and user.sponsor_obj in self.activity.sponsors.all()
+                or (EighthSponsor.objects.filter(user=user).exists() and user.sponsor_obj in self.activity.sponsors.all())
             )
         )
 
@@ -205,7 +203,7 @@ def is_visible_requester(self, user):
 
     def is_visible_submitter(self, user):
         try:
-            return self.user == user or self.announcementrequest and user == self.announcementrequest.user
+            return self.user == user or (self.announcementrequest and user == self.announcementrequest.user)
         except get_user_model().DoesNotExist:
             return False
 

intranet/apps/announcements/views.py

@@ -436,7 +436,7 @@ def delete_announcement_view(request, announcement_id):
     """
     announcement = get_object_or_404(Announcement, id=announcement_id)
 
-    if not (request.user.is_announcements_admin or announcement.is_club_announcement and announcement.can_modify(request.user)):
+    if not (request.user.is_announcements_admin or (announcement.is_club_announcement and announcement.can_modify(request.user))):
         messages.error(request, "You do not have permission to delete this announcement.")
         return redirect("index")
 

intranet/apps/auth/helpers.py

@@ -11,8 +11,7 @@ def change_password(form_data):
     if form_data:
         form_data["username"] = re.sub(r"\W", "", form_data["username"])
     if (
-        form_data
-        and form_data["username"] == "unknown"
+        (form_data and form_data["username"] == "unknown")
         or form_data["old_password"] is None
         or form_data["new_password"] is None
         or form_data["new_password_confirm"] is None

intranet/apps/bus/migrations/0009_busdelay.py

@@ -0,0 +1,22 @@
+# Generated by Django 3.2.25 on 2025-05-20 23:50
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('bus', '0008_alter_busannouncement_message'),
+    ]
+
+    operations = [
+        migrations.CreateModel(
+            name='BusDelay',
+            fields=[
+                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
+                ('bus_number', models.CharField(max_length=10)),
+                ('reason', models.TextField()),
+                ('timestamp', models.DateTimeField(auto_now_add=True)),
+            ],
+        ),
+    ]

intranet/apps/bus/migrations/0010_auto_20250520_2301.py

@@ -0,0 +1,21 @@
+# Generated by Django 3.2.25 on 2025-05-21 03:01
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('bus', '0009_busdelay'),
+    ]
+
+    operations = [
+        migrations.DeleteModel(
+            name='BusDelay',
+        ),
+        migrations.AddField(
+            model_name='route',
+            name='reason',
+            field=models.CharField(blank=True, max_length=50),
+        ),
+    ]

intranet/apps/bus/models.py

@@ -10,12 +10,14 @@ class Route(models.Model):
     space = models.CharField(max_length=4, blank=True)
     bus_number = models.CharField(max_length=5, blank=True)
     status = models.CharField("arrival status", choices=ARRIVAL_STATUSES, max_length=1, default="o")
+    reason = models.CharField(max_length=50, blank=True)
 
     def reset_status(self):
         """Reset status to (on time)"""
         self.status = "o"
         self.space = ""
-        self.save(update_fields=["status", "space"])
+        self.reason = ""
+        self.save(update_fields=["status", "space", "reason"])
 
     def __str__(self):
         return self.route_name

intranet/apps/bus/tasks.py

@@ -1,5 +1,10 @@
+import requests
+from asgiref.sync import async_to_sync
+from bs4 import BeautifulSoup
 from celery import shared_task
 from celery.utils.log import get_task_logger
+from channels.layers import get_channel_layer
+from django.utils import timezone
 
 from .models import Route
 
@@ -12,3 +17,54 @@ def reset_routes() -> None:
 
     for route in Route.objects.all():
         route.reset_status()
+
+
+@shared_task
+def fetch_fcps_bus_delays():
+    now = timezone.localtime(timezone.now())
+    # Check if the current time is within 6-9 AM or 3-6 PM from Mon-Fri
+    if now.weekday() in (5, 6):
+        return
+    if not (now.hour in range(6, 9) and now.hour in range(15, 18)):
+        return
+    url = "https://busdelay.fcps.edu"
+    try:
+        response = requests.get(url, timeout=10)
+        response.raise_for_status()
+    except Exception as e:
+        logger.error("Error fetching URL: %s", e)
+        return
+
+    soup = BeautifulSoup(response.text, "html.parser")
+    rows = soup.select("table tr")
+    # In case a row is formatted incorrectly, check the amount of cells to make sure it contains all information
+    if not rows or len(rows) < 2:
+        logger.warning("Not a complete row with all bus information")
+        return
+    # Sort out the JEFFERSON HIGH bus delays
+    for row in rows[1:]:
+        cells = row.find_all("td")
+        if len(cells) >= 4 and cells[0].text.strip() == "JEFFERSON HIGH":
+            route_name = cells[1].text.strip().split()[0]
+            reason = cells[3].text.strip()
+            try:
+                obj = Route.objects.get(route_name=route_name)
+                # Only can update the status if it is on default status (on time)
+                if obj.status != "a":
+                    obj.status = "d"
+                    obj.reason = reason
+                    obj.save(update_fields=["status", "reason"])
+                    logger.info("Updated route %s with delay: %s", route_name, reason)
+                    channel_layer = get_channel_layer()
+                    all_routes = list(Route.objects.values())
+                    async_to_sync(channel_layer.group_send)(
+                        "bus",
+                        {
+                            "type": "bus.update",
+                            "message": {
+                                "allRoutes": all_routes,
+                            },
+                        },
+                    )
+            except Route.DoesNotExist:
+                logger.error("Route with route_name %s does not exist", route_name)