Skip to content

fix(ui): consistency when rejecting/approving events #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ZamanZahid wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(ui): consistency when rejecting/approving events #1830

ZamanZahid wants to merge 1 commit into from

Conversation

@ZamanZahid
Copy link

@ZamanZahid ZamanZahid commented Sep 14, 2025

closes #1825

Proposed changes

  • keeps ?show=all, after approve/reject

@ZamanZahid ZamanZahid requested a review from a team as a code owner September 14, 2025 01:50
@coveralls
Copy link

coveralls commented Sep 14, 2025

Coverage Status

coverage: 79.453% (+0.06%) from 79.398%
when pulling dfb3d02 on ZamanZahid:dev
into aacf793 on tjcsl:dev.

aarushtools
aarushtools requested changes Nov 26, 2025
View reviewed changes
Copy link
Member

@aarushtools aarushtools left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution is innovative, but can you use request.GET.urlencode() and just add that to the url instead. It's more verbose and http_referer could have bad input. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aarushtools aarushtools aarushtools requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix UI consistency when rejecting/approving events

3 participants

@ZamanZahid @coveralls @aarushtools