Skip to content

Conversation

@mtigas
Copy link

@mtigas mtigas commented Aug 17, 2012

Changes/Fixes

  • Un-break. (Last commit did not work in 1.4.X, probably due to JS issues.)
  • Works in Django 1.3.X and 1.4.X. (And running in production on spokesman.com.)
  • Moved example project out of orderable.tests to it's own demosrc dir in the repo.
  • More comprehensive README.
  • Ensure that inline drag-and-drop cannot move "Add new X" row or move items below that row.
  • Fix issue where text inputs in TabularInline could not be edited (because jQueryUI sortable was catching mouse event)
  • New BaseOrderableModel that provides all of the OrderableModel behavior without defining order field. (So that order can be defined manually by an implementing class.) Done because I needed to throw this on top of an existing model.
  • Show "tip" text (similar to change list tip) above orderable inlines.
  • Now uses staticfiles instead of relying on user to copy orderable.js into MEDIA_ROOT.
  • Probably some other things I forgot.

Bugs/Notices

  • Addition of tips (stacked.html, tabular.html) will require regenerating translations.
  • Those two files possibly need better wording/HTML/something?

Upgrade caveats

  • Now relies on staticfiles. (Admin in 1.4+ relies on it, anyway.) Existing installs can remove the previously user-copied orderable.js.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (and L37 below) are basically equivalent to {% static "orderable/orderable.js" %}. Don't know why it's not in django docs, but simply prepending STATIC_URL isn’t always helpful (especially when using django-storages + S3).

@tkaemming
Copy link
Owner

@mtigas
Copy link
Author

mtigas commented Aug 29, 2012

even funnier is that someone else took the name in the intervening two years

https://github.com/incuna/django-orderable

http://pypi.python.org/pypi/django-orderable

@vdboor
Copy link

vdboor commented Apr 10, 2013

Bummer. :(

@tkaemming Could this stuff still be merged back, or released on PyPI?
I'd rather let my packages depend on a PyPI release instead of a github commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants