Option to redownload module

Author: Osanosa

app/apk/src/main/java/com/topjohnwu/magisk/dialog/ReinstallConfirmationDialog.kt

@@ -0,0 +1,29 @@
+
+package com.topjohnwu.magisk.dialog
+
+import android.R as AndroidR
+import com.topjohnwu.magisk.core.R as CoreR
+import com.topjohnwu.magisk.core.model.module.OnlineModule
+import com.topjohnwu.magisk.events.DialogBuilder
+import com.topjohnwu.magisk.ui.module.ModuleViewModel
+import com.topjohnwu.magisk.view.MagiskDialog
+
+class ReinstallConfirmationDialog(
+    private val viewModel: ModuleViewModel,
+    private val item: OnlineModule
+) : DialogBuilder {
+    override fun build(dialog: MagiskDialog) {
+        dialog.apply {
+            setTitle(CoreR.string.module_reinstall_title)
+            setMessage(CoreR.string.module_reinstall_message)
+            setButton(MagiskDialog.ButtonType.POSITIVE) {
+                text = CoreR.string.module_reinstall
+                onClick { viewModel.downloadPressed(item) }
+            }
+            setButton(MagiskDialog.ButtonType.NEGATIVE) {
+                text = AndroidR.string.cancel
+            }
+            setCancelable(true)
+        }
+    }
+} 

app/apk/src/main/java/com/topjohnwu/magisk/ui/module/ModuleViewModel.kt

@@ -19,6 +19,7 @@ import com.topjohnwu.magisk.databinding.diffList
 import com.topjohnwu.magisk.databinding.set
 import com.topjohnwu.magisk.dialog.LocalModuleInstallDialog
 import com.topjohnwu.magisk.dialog.OnlineModuleInstallDialog
+import com.topjohnwu.magisk.dialog.ReinstallConfirmationDialog
 import com.topjohnwu.magisk.events.GetContentEvent
 import com.topjohnwu.magisk.events.SnackbarEvent
 import kotlinx.coroutines.Dispatchers
@@ -91,6 +92,15 @@ class ModuleViewModel : AsyncLoadViewModel() {
         LocalModuleInstallDialog(this, uri, displayName).show()
     }
 
+    fun onUpdateClicked(item: LocalModuleRvItem) {
+        val updateInfo = item.item.updateInfo ?: return
+        if (item.updateReady) {
+            downloadPressed(updateInfo)
+        } else {
+            ReinstallConfirmationDialog(this, updateInfo).show()
+        }
+    }
+
     @Parcelize
     class UriCallback : ContentResultCallback {
         override fun onActivityResult(result: Uri) {

app/apk/src/main/res/layout/item_module_md2.xml

@@ -132,14 +132,15 @@
 
                 <Button
                     android:id="@+id/module_update"
-                    style="@style/WidgetFoundation.Button.Text"
+                    style="@style/Widget.Foundation.Button.Text"
                     goneUnless="@{item.showUpdate}"
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
                     android:clickable="true"
-                    android:enabled="@{item.updateReady}"
+                    android:enabled="true"
                     android:focusable="true"
-                    android:onClick="@{() -> viewModel.downloadPressed(item.item.updateInfo)}"
+                    android:alpha="@{item.updateReady ? 1.0f : 0.38f}"
+                    android:onClick="@{() -> viewModel.onUpdateClicked(item)}"
                     android:text="@string/update"
                     android:textAllCaps="false"
                     app:icon="@drawable/ic_update_md2"

app/core/src/main/res/values/strings.xml

@@ -116,6 +116,9 @@
     <string name="module_empty">No module installed</string>
     <string name="confirm_install">Install module %1$s?</string>
     <string name="confirm_install_title">Install confirmation</string>
+    <string name="module_reinstall_title">Reinstall Module</string>
+    <string name="module_reinstall_message">This module is already up-to-date. Do you want to redownload and reinstall it?</string>
+    <string name="module_reinstall">Reinstall</string>
 
     <!--Settings-->
     <string name="settings_dark_mode_title">Theme mode</string>