Merge pull request #273 from tosdr/fix-empty-services-home-page

scope on services so only services with points show up on home page

Author: Christopher Talib

app/controllers/pages_controller.rb

@@ -3,7 +3,7 @@ def home
     if params[:query]
       @services = Service.where('name ILIKE ? or grade ILIKE ?', "%#{params[:query]}%", "%#{params[:query]}%")
     else
-      @services = Service.all
+      @services = Service.with_points
     end
   end
 end

app/models/service.rb

@@ -6,6 +6,8 @@ class Service < ApplicationRecord
   validates :name, uniqueness: true
   validates :url, presence: true
 
+  scope :with_points, -> { joins(:points).where.not(points: []).distinct }
+
   def points_by_topic(query)
     points.joins(:topic).where("topics.title ILIKE ?", "%#{query}%")
   end