-
Notifications
You must be signed in to change notification settings - Fork 169
Description
These two are redundant, keep one:
"The return type annotation is also unnecessary, because TypeScript recognizes that when evaluating isProblem || isSolution, a boolean variable will be returned."
"The return type annotation could also be pruned while maintaining the correct inference. TypeScript recognizes that when evaluating isProblem || isSolution, a boolean variable will be returned, rendering the annotation needless."
"The only annotation that needs to say"... -> stay
"even if we remove its annotation.:" -> unnecessary period
"properly utilizing inference system" -> add "the" before inference system
"operater tells TypeScript to remove" -> operator
"With this change, errors will appearing as required" -> appear
"Using of satisfies is a good practice" -> The use of satisfies...
"Inside of the tests we expect that accessing properties of the routes object should return Home and About instead of interpreting these as literals:"
The text and the code are contradictory. The code is explicitly testing for literal string types ("Home", "About"), but the text suggests we want to avoid literal interpretation.
Suggestion -> "Inside of the tests we expect that accessing properties of the routes object should return the literal types Home and About instead of the general string type:"
"Now our tests pass expected." -> as expected
"This setup of combining as const and satisfies is ideal when you need a particular shape for a configuration object and want while enforcing immutability." -> either delete "and want" or replace "while enforcing" with "to enforce"