Skip to content

Commit cfda275

Browse files
dguidoclaude
andauthored
Simplify codebase: modernize loops, split templates, improve CI (#14891)
* Simplify codebase: remove dead venv files, consolidate loops, modernize patterns - Delete 8 empty venv.yml files that were remnants of pyproject.toml migration - Remove corresponding import_tasks references from cloud provider main.yml files - Consolidate server.yml async polling from 4 copy-paste blocks to 1 loop - Wrap sequential VPN service imports in a block with single when condition - Replace deprecated with_indexed_items with modern loop/loop_control syntax These changes reduce maintenance burden by: - Eliminating 8 files that served no purpose - Reducing server.yml by ~20 lines while improving readability - Removing Ansible deprecation warnings for with_indexed_items - Making the parallel/sequential execution paths easier to maintain 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * Fix template variable and undefined job variable bugs - Fix client.conf.j2 to use `item` instead of `item.1` to match modern loop syntax (loop with index_var instead of with_indexed_items) - Fix server.yml _vpn_jobs to use `| default({})` for job variables that may be undefined when running with tags (e.g., IPsec-only) - Update test_template_rendering.py to pass item as string instead of tuple, matching the new loop behavior Fixes CI failures from PR #14891 that were correctly identified by the Claude Code bot review. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: Claude <[email protected]>
1 parent ba72972 commit cfda275

File tree

21 files changed

+60
-123
lines changed

21 files changed

+60
-123
lines changed

roles/cloud-azure/tasks/main.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
---
2-
- name: Build python virtual environment
3-
import_tasks: venv.yml
4-
52
- name: Include prompts
63
import_tasks: prompts.yml
74

roles/cloud-azure/tasks/venv.yml

Lines changed: 0 additions & 3 deletions
This file was deleted.

roles/cloud-cloudstack/tasks/main.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
---
2-
- name: Build python virtual environment
3-
import_tasks: venv.yml
4-
52
- name: Include prompts
63
import_tasks: prompts.yml
74

roles/cloud-cloudstack/tasks/venv.yml

Lines changed: 0 additions & 3 deletions
This file was deleted.

roles/cloud-ec2/tasks/main.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
---
2-
- name: Build python virtual environment
3-
import_tasks: venv.yml
4-
52
- name: Include prompts
63
import_tasks: prompts.yml
74

roles/cloud-ec2/tasks/venv.yml

Lines changed: 0 additions & 3 deletions
This file was deleted.

roles/cloud-gce/tasks/main.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
---
2-
- name: Build python virtual environment
3-
import_tasks: venv.yml
4-
52
- name: Include prompts
63
import_tasks: prompts.yml
74

roles/cloud-gce/tasks/venv.yml

Lines changed: 0 additions & 3 deletions
This file was deleted.

roles/cloud-hetzner/tasks/main.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
---
2-
- name: Build python virtual environment
3-
import_tasks: venv.yml
4-
52
- name: Include prompts
63
import_tasks: prompts.yml
74

roles/cloud-hetzner/tasks/venv.yml

Lines changed: 0 additions & 3 deletions
This file was deleted.

0 commit comments

Comments
 (0)