Skip to content

Conversation

@mina-parham
Copy link
Contributor

No description provided.

@mina-parham mina-parham marked this pull request as draft November 21, 2025 16:28
mina-parham and others added 28 commits November 21, 2025 12:10
@mina-parham mina-parham marked this pull request as ready for review November 21, 2025 22:39
@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 78.12500% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
api/transformerlab/services/experiment_init.py 75.86% 6 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

api/api.py Outdated
app.include_router(batched_prompts.router, dependencies=[Depends(get_user_and_team)])
app.include_router(remote.router, dependencies=[Depends(get_user_and_team)])
app.include_router(fastchat_openai_api.router, dependencies=[Depends(get_user_and_team)])
app.include_router(teams.router)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I submitted a question about why we don't apply standard auth on the teams endpoint on discord.

api/api.py Outdated
spawn_fastchat_controller_subprocess()

# Skip subprocess spawning in test mode
if os.environ.get("PYTEST_CURRENT_TEST") is None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this one set?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this

@mina-parham mina-parham force-pushed the add/auth-to-all-endpoints branch 2 times, most recently from 82a3fc4 to 35b0e8d Compare November 24, 2025 22:11
@mina-parham mina-parham merged commit 9716a41 into main Nov 24, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants