From 68a819b6fb04b13735b99b05fcf0657e255abb6e Mon Sep 17 00:00:00 2001 From: Dennis Kaarsemaker Date: Fri, 22 Oct 2021 19:04:02 +0200 Subject: [PATCH 1/2] Fix error message when no private key is provided This error had me confused for a minute. Had to read this file to realize that I passed an empty string as PrivateKeyPath --- client.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client.go b/client.go index 87bc3d4..1bb7736 100644 --- a/client.go +++ b/client.go @@ -69,7 +69,7 @@ func newClient(config ClientConfiguration) (*client, error) { // check if token or private key is set if len(config.Token) == 0 && config.PrivateKeyReader == nil { - return &client{}, errors.New("PrivateKeyReader, token or PrivateKeyReader is required") + return &client{}, errors.New("PrivateKeyPath, token or PrivateKeyReader is required") } if config.PrivateKeyReader != nil { From b5de5ba0b3e55297730184091ca51a533a27bf4e Mon Sep 17 00:00:00 2001 From: Dennis Kaarsemaker Date: Thu, 11 Nov 2021 09:28:32 +0100 Subject: [PATCH 2/2] Update the fixed PrivateKeyPath error message in the test --- client_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client_test.go b/client_test.go index 03d672b..dea2246 100644 --- a/client_test.go +++ b/client_test.go @@ -45,7 +45,7 @@ func TestNewClient(t *testing.T) { // ClientConfig with only AccountName set should raise error about private keys _, err = NewClient(cc) if assert.Errorf(t, err, "expecting private key, token required error") { - assert.EqualError(t, err, "PrivateKeyReader, token or PrivateKeyReader is required") + assert.EqualError(t, err, "PrivateKeyPath, token or PrivateKeyReader is required") } cc.PrivateKeyReader = iotest.TimeoutReader(bytes.NewReader([]byte{0, 1}))