Skip to content

Commit 2bf9029

Browse files
committed
Simplify mvn install commands with POM files
- Remove redundant -DgroupId, -DartifactId, -Dversion, -Dpackaging - When using -DpomFile, Maven extracts metadata from POM automatically - Cleaner commands that rely on POM for all artifact information
1 parent cbd3916 commit 2bf9029

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

.github/unsafe/build-custom-armeria.sh

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,6 @@ curl -sL -o "armeria-${VERSION}.pom" "https://repo1.maven.org/maven2/com/linecor
3333
# Install core JAR to Maven local repository with POM
3434
mvn install:install-file -q \
3535
-Dfile="$CORE_JAR" \
36-
-DpomFile="armeria-${VERSION}.pom" \
37-
-DgroupId=com.linecorp.armeria \
38-
-DartifactId=armeria \
39-
-Dversion="${VERSION}" \
40-
-Dpackaging=jar
36+
-DpomFile="armeria-${VERSION}.pom"
4137

4238
echo "armeria ${VERSION} built and installed (UNSAFE disabled)."

.github/unsafe/build-custom-protobuf.sh

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,6 @@ curl -sL -o "protobuf-java-${VERSION}.pom" "https://repo1.maven.org/maven2/com/g
3636
# Install to Maven local repository with POM
3737
mvn install:install-file -q \
3838
-Dfile="protobuf-java-${VERSION}.jar" \
39-
-DpomFile="protobuf-java-${VERSION}.pom" \
40-
-DgroupId=com.google.protobuf \
41-
-DartifactId=protobuf-java \
42-
-Dversion="${VERSION}" \
43-
-Dpackaging=jar
39+
-DpomFile="protobuf-java-${VERSION}.pom"
4440

4541
echo "protobuf-java ${VERSION} built and installed (UNSAFE disabled)."

0 commit comments

Comments
 (0)