Skip to content

Commit aae3bed

Browse files
committed
fix: keep protobuf-bom to avoid protoc version conflicts
1 parent 74b572d commit aae3bed

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

.github/unsafe/build-custom-protobuf.sh

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,7 @@ mvn install:install-file -q \
4343

4444
# Update dependencies
4545
DEPS="${SCRIPT_DIR}/../../dependencyManagement/build.gradle.kts"
46-
sed -i '/com\.google\.protobuf:protobuf-bom:/d' "${DEPS}"
47-
sed -i '/com\.google\.protobuf:protobuf-java/d' "${DEPS}"
46+
sed -i '/com\.google\.protobuf:protobuf-java:/d' "${DEPS}"
4847
sed -i '/^val DEPENDENCIES = listOf(/a\ "com.google.protobuf:protobuf-java:'"${CUSTOM_VERSION}"'",' "${DEPS}"
49-
sed -i '/^val DEPENDENCIES = listOf(/a\ "com.google.protobuf:protobuf-java-util:'"${ORIGINAL_VERSION}"'",' "${DEPS}"
5048

5149
echo "protobuf-java ${CUSTOM_VERSION} built and installed (UNSAFE disabled)."

dependencyManagement/build.gradle.kts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,10 @@ val DEPENDENCY_BOMS = listOf(
4141
)
4242

4343
val DEPENDENCIES = listOf(
44+
"com.linecorp.armeria:armeria:1.33.4-SNAPSHOT",
45+
"com.google.protobuf:protobuf-java:4.32.2-SNAPSHOT",
4446
"org.junit.jupiter:junit-jupiter-api:${junitVersion}",
4547
"org.junit.jupiter:junit-jupiter-params:${junitVersion}",
46-
"com.linecorp.armeria:armeria:${armeriaVersion}",
4748
"com.linecorp.armeria:armeria-grpc:${armeriaVersion}",
4849
"com.linecorp.armeria:armeria-grpc-protocol:${armeriaVersion}",
4950
"com.linecorp.armeria:armeria-junit5:${armeriaVersion}",

0 commit comments

Comments
 (0)