Skip to content

Commit d89e230

Browse files
committed
Fix failure of Delta Lake testCaseUpdatePartitionColumnFails
1 parent b5e2b24 commit d89e230

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

testing/trino-product-tests/src/main/java/io/trino/tests/product/deltalake/TestDeltaLakeWriteDatabricksCompatibility.java

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@
4646
import static io.trino.tests.product.utils.QueryExecutors.onDelta;
4747
import static io.trino.tests.product.utils.QueryExecutors.onTrino;
4848
import static java.lang.String.format;
49-
import static java.util.Locale.ENGLISH;
5049
import static java.util.function.Predicate.not;
5150
import static java.util.stream.Collectors.joining;
5251
import static java.util.stream.Collectors.toList;
@@ -207,15 +206,8 @@ public void testCaseUpdateInPartition(String partitionColumn)
207206
public void testCaseUpdatePartitionColumnFails(String partitionColumn)
208207
{
209208
try (CaseTestTable table = new CaseTestTable("update_case_compat", partitionColumn, List.of(row(1, 1, 1)))) {
210-
// TODO: The test fails for uppercase columns because the statement analyzer compares the column name case-sensitively.
211-
if (!partitionColumn.equals(partitionColumn.toLowerCase(ENGLISH))) {
212-
assertQueryFailure(() -> onTrino().executeQuery(format("UPDATE delta.default.%s SET %s = 0 WHERE lower = 1", table.name(), partitionColumn)))
213-
.hasMessageMatching(".*The UPDATE SET target column .* doesn't exist");
214-
}
215-
else {
216-
onTrino().executeQuery(format("UPDATE delta.default.%s SET %s = 0 WHERE lower = 1", table.name(), partitionColumn));
217-
assertTable(table, table.rows().map(row -> row.withPartition(0)));
218-
}
209+
onTrino().executeQuery(format("UPDATE delta.default.%s SET %s = 0 WHERE lower = 1", table.name(), partitionColumn));
210+
assertTable(table, table.rows().map(row -> row.withPartition(0)));
219211
}
220212
}
221213

0 commit comments

Comments
 (0)