Run every hour to make overheads low

Author: HenryTraill

chronos/worker.py

@@ -200,7 +200,7 @@ async def lifespan(app: FastAPI):
     scheduler.shutdown()
 
 
-@scheduler.scheduled_job('cron', hour=0, minute=0)
+@scheduler.scheduled_job('interval', hours=1)
 async def delete_old_logs_job():
     """
     We run cron job at midnight every day that wipes all WebhookLogs older than 15 days
@@ -227,29 +227,30 @@ def get_count(date_to_delete_before: datetime) -> int:
 
 
 @celery_app.task
-@logfire.no_auto_trace
 def _delete_old_logs_job():
     # with logfire.span('Started to delete old logs'):
     with Session(engine) as db:
         # Get all logs older than 15 days
         date_to_delete_before = datetime.now(UTC) - timedelta(days=15)
-        # with logfire.span(
-        #     'Deleting webhooks for {date_to_delete_before=}', date_to_delete_before=date_to_delete_before
-        # ):
         count = get_count(date_to_delete_before)
-        delete_limit = 4999
-        while count > 0:
-            app_logger.info(f'Deleting {count} logs')
-            logs_to_delete = db.exec(
-                select(WebhookLog).where(WebhookLog.timestamp < date_to_delete_before).limit(delete_limit)
-            ).all()
-            delete_statement = delete(WebhookLog).where(WebhookLog.id.in_(log.id for log in logs_to_delete))
-            db.exec(delete_statement)
-            db.commit()
-            count -= delete_limit
-
-            del logs_to_delete
-            del delete_statement
-            gc.collect()
+        with logfire.span(
+            'Deleting {count=} webhooks before {date_to_delete_before=}',
+            date_to_delete_before=date_to_delete_before,
+            count=count,
+        ):
+            delete_limit = 4999
+            while count > 0:
+                app_logger.info(f'Deleting {count} logs')
+                logs_to_delete = db.exec(
+                    select(WebhookLog).where(WebhookLog.timestamp < date_to_delete_before).limit(delete_limit)
+                ).all()
+                delete_statement = delete(WebhookLog).where(WebhookLog.id.in_(log.id for log in logs_to_delete))
+                db.exec(delete_statement)
+                db.commit()
+                count -= delete_limit
+
+                del logs_to_delete
+                del delete_statement
+                gc.collect()
 
     cache.delete(DELETE_JOBS_KEY)